Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra debugging & http protocol downgrade (Issue #314) #327

Merged
merged 4 commits into from
Jan 5, 2019
Merged

Add extra debugging & http protocol downgrade (Issue #314) #327

merged 4 commits into from
Jan 5, 2019

Conversation

abraunegg
Copy link
Owner

  • Add --force-http-1.1 flag to downgrade any HTTP/2 curl operations to HTTP 1.1 protocol
  • Explicitly set all bool items to false at initialisation
  • Update --display-config to display sync_list if configured
  • Add debug handling to display when sync_list is loaded
  • Add debug handling to output the handling of OneDrive changes

@abraunegg
Add extra debugging & http protocol downgrade
a0f8690 
* Add --force-http-1.1 flag to downgrade any HTTP/2 curl operations to HTTP 1.1 protocol
* Explicitly set all bool items to false at initialisation
* Update --display-config to display sync_list if configured
* Add debug handling to display when sync_list is loaded
* Add debug handling to output the handling of OneDrive changes
@abraunegg
update extra debugging
e946269 
* update extra debugging
@abraunegg abraunegg assigned norbusan and unassigned norbusan Jan 4, 2019
@abraunegg abraunegg requested a review from norbusan January 4, 2019 00:05
@abraunegg
Copy link
Owner Author

abraunegg commented Jan 4, 2019 •
edited
Loading

Note: --force-http-1.1 flag resolves #314, potentially will solve #323 & #324 as well

@norbusan
Copy link
Collaborator

norbusan commented Jan 4, 2019

CI testing reveals a crash, @abraunegg can you please look into that?

@abraunegg
Update sync.d
9e01d53 
* Fix introduced core.exception.AssertError@src/itemdb.d(341): Assertion failure
@abraunegg abraunegg mentioned this pull request Jan 4, 2019
Closed
3 tasks
@abraunegg
Copy link
Owner Author

@norbusan
CI testing crash should be taken care of now

@abraunegg abraunegg mentioned this pull request Jan 5, 2019
Merged
@abraunegg
Copy link
Owner Author

superseded by #328

@abraunegg abraunegg mentioned this pull request Jan 5, 2019
Merged
@abraunegg abraunegg changed the title Add extra debugging & http protocol downgrade Add extra debugging & http protocol downgrade (Issue #314) Jan 5, 2019
norbusan
norbusan approved these changes Jan 5, 2019
View reviewed changes
Copy link
Collaborator

@norbusan norbusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build works, basic tests on my local onedrive and a test onedrive worked. Code changes look fine to me.

@abraunegg abraunegg merged commit 1fa7e5f into master Jan 5, 2019
@abraunegg abraunegg deleted the extra-debugging-and-http-downgrade branch January 5, 2019 23:59
@abraunegg abraunegg mentioned this pull request Jan 6, 2019
Closed
@abraunegg abraunegg added this to the 2.2.5 milestone Jan 6, 2019
@lock
Copy link

lock bot commented Jan 13, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Jan 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@norbusan norbusan norbusan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.5
Development

Successfully merging this pull request may close these issues.
2 participants
@abraunegg @norbusan