-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: refactor infra tests part 5 #7705
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7705 +/- ##
============================================
- Coverage 28.54% 28.54% -0.01%
Complexity 2059 2059
============================================
Files 1249 1249
Lines 154147 154181 +34
Branches 3040 3039 -1
============================================
Hits 44005 44005
- Misses 108328 108363 +35
+ Partials 1814 1813 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
11696a5
to
fabef02
Compare
fabef02
to
c7a5f4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for letting all OpenApi PRs being merged before this one, it really helped! 😄
Just a few minor details and we're good to go 🚀
c7a5f4f
to
1ba6ba3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for re-arranging the PR to avoid merging short-lived code.
A few more changes and we're good :)
Part of #6980
create_mini_infra
is a temporary infra, and will be replaced bysmall_infra
onceInfra::persist
is refactored.