Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: refactor infra tests part 5 #7705

Merged
merged 5 commits into from
Jun 28, 2024

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Jun 13, 2024

Part of #6980

create_mini_infra is a temporary infra, and will be replaced by small_infra once Infra::persist is refactored.

@hamz2a hamz2a requested a review from a team as a code owner June 13, 2024 09:34
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 40.62500% with 19 lines in your changes missing coverage. Please review.

Project coverage is 28.54%. Comparing base (c1a55f4) to head (87c26dc).
Report is 10 commits behind head on dev.

Files Patch % Lines
editoast/src/views/infra/routes.rs 37.50% 10 Missing ⚠️
editoast/src/views/infra/pathfinding.rs 0.00% 7 Missing ⚠️
editoast/src/views/infra/objects.rs 77.77% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7705      +/-   ##
============================================
- Coverage     28.54%   28.54%   -0.01%     
  Complexity     2059     2059              
============================================
  Files          1249     1249              
  Lines        154147   154181      +34     
  Branches       3040     3039       -1     
============================================
  Hits          44005    44005              
- Misses       108328   108363      +35     
+ Partials       1814     1813       -1     
Flag Coverage Δ
core 74.95% <ø> (-0.06%) ⬇️
editoast 71.65% <40.62%> (-0.11%) ⬇️
front 10.01% <ø> (+0.01%) ⬆️
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leovalais
Copy link
Contributor

Thanks for this PR. Can we please delay merging it until the OpenApi migration is complete? Sadly there's some overlap that I won't be able to fix since I'll be in vacation, and I'd like these to be merged asap :/

Cf. #7553 #7677 #7686

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hamz2a hamz2a force-pushed the hai/editoast-refactor-infra-tests-part-5 branch 2 times, most recently from 11696a5 to fabef02 Compare June 27, 2024 07:27
@hamz2a hamz2a force-pushed the hai/editoast-refactor-infra-tests-part-5 branch from fabef02 to c7a5f4f Compare June 27, 2024 09:55
@leovalais leovalais self-requested a review June 27, 2024 10:24
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for letting all OpenApi PRs being merged before this one, it really helped! 😄

Just a few minor details and we're good to go 🚀

editoast/src/views/infra/auto_fixes/mod.rs Outdated Show resolved Hide resolved
editoast/src/views/infra/objects.rs Outdated Show resolved Hide resolved
@hamz2a hamz2a force-pushed the hai/editoast-refactor-infra-tests-part-5 branch from c7a5f4f to 1ba6ba3 Compare June 28, 2024 07:35
@hamz2a hamz2a requested a review from leovalais June 28, 2024 08:52
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for re-arranging the PR to avoid merging short-lived code.
A few more changes and we're good :)

editoast/src/views/infra/objects.rs Outdated Show resolved Hide resolved
editoast/src/views/infra/routes.rs Outdated Show resolved Hide resolved
@hamz2a hamz2a added this pull request to the merge queue Jun 28, 2024
Merged via the queue into dev with commit f8e6fef Jun 28, 2024
17 checks passed
@hamz2a hamz2a deleted the hai/editoast-refactor-infra-tests-part-5 branch June 28, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants