Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utoipa annotation to edition endpoint #7553

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Conversation

leovalais
Copy link
Contributor

@leovalais leovalais commented May 29, 2024

Also moves RailjsonObject into editoast_schemas under InfraObject.

Tip

Review each commit individually.

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

Attention: Patch coverage is 89.84772% with 40 lines in your changes missing coverage. Please review.

Project coverage is 28.60%. Comparing base (66b26ab) to head (ee9c6f5).

Files Patch % Lines
editoast/src/infra_cache/operation/mod.rs 79.78% 19 Missing ⚠️
...ditoast/editoast_schemas/src/infra/infra_object.rs 93.82% 5 Missing ⚠️
editoast/src/views/infra/auto_fixes/mod.rs 28.57% 5 Missing ⚠️
front/src/reducers/editor/thunkActions.ts 0.00% 5 Missing ⚠️
front/src/common/api/osrdEditoastApi.ts 97.41% 4 Missing ⚠️
...itoast/src/views/infra/auto_fixes/track_section.rs 50.00% 1 Missing ⚠️
front/src/applications/editor/data/utils.ts 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7553      +/-   ##
============================================
+ Coverage     28.54%   28.60%   +0.06%     
  Complexity     2038     2038              
============================================
  Files          1243     1244       +1     
  Lines        153525   153665     +140     
  Branches       3008     3008              
============================================
+ Hits          43825    43963     +138     
- Misses       107909   107911       +2     
  Partials       1791     1791              
Flag Coverage Δ
core 75.03% <ø> (ø)
editoast 72.12% <86.95%> (+0.04%) ⬆️
front 9.90% <93.90%> (+0.07%) ⬆️
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leovalais leovalais force-pushed the lva/utoipa-infra-edit branch 3 times, most recently from 7997559 to 052104b Compare May 30, 2024 09:13
@leovalais leovalais marked this pull request as ready for review May 30, 2024 10:07
@leovalais leovalais requested review from a team as code owners May 30, 2024 10:07
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly some renaming, nice job.

editoast/src/infra_cache/mod.rs Outdated Show resolved Hide resolved
editoast/src/infra_cache/operation/create.rs Outdated Show resolved Hide resolved
editoast/src/infra_cache/operation/mod.rs Outdated Show resolved Hide resolved
editoast/src/views/infra/auto_fixes/mod.rs Outdated Show resolved Hide resolved
editoast/src/views/infra/auto_fixes/mod.rs Outdated Show resolved Hide resolved
@leovalais leovalais force-pushed the lva/utoipa-infra-edit branch from 052104b to aa3a995 Compare May 30, 2024 14:47
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (reviewed + tested)

@leovalais leovalais self-assigned this May 31, 2024
@leovalais leovalais force-pushed the lva/utoipa-infra-edit branch from aa3a995 to 2189369 Compare May 31, 2024 15:54
woshilapin

This comment was marked as off-topic.

Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (tested)

@leovalais leovalais force-pushed the lva/utoipa-infra-edit branch from 9ff4deb to e5e6902 Compare June 14, 2024 12:51
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, tested it works great. Just left some comments.

front/src/applications/editor/types.ts Outdated Show resolved Hide resolved
front/src/applications/editor/types.ts Outdated Show resolved Hide resolved
front/src/applications/editor/data/utils.ts Outdated Show resolved Hide resolved
@leovalais leovalais force-pushed the lva/utoipa-infra-edit branch from e5e6902 to 63e3914 Compare June 17, 2024 08:12
@leovalais leovalais force-pushed the lva/utoipa-infra-edit branch from 63e3914 to ee9c6f5 Compare June 17, 2024 08:12
@leovalais leovalais requested a review from SharglutDev June 17, 2024 08:13
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

@leovalais leovalais added this pull request to the merge queue Jun 17, 2024
Merged via the queue into dev with commit 09eead2 Jun 17, 2024
17 checks passed
@leovalais leovalais deleted the lva/utoipa-infra-edit branch June 17, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants