Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bye bye openapi_legacy.yaml 🥳🥳 #7686

Merged
merged 4 commits into from
Jun 27, 2024
Merged

Bye bye openapi_legacy.yaml 🥳🥳 #7686

merged 4 commits into from
Jun 27, 2024

Conversation

leovalais
Copy link
Contributor

@leovalais leovalais commented Jun 11, 2024

FINALLY

  • removes openapi_legacy
  • drop merging support
  • a few fixes that went unnoticed

@leovalais leovalais changed the title lva/good riddance Bye bye openapi_legacy.yaml 🥳🥳 Jun 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 25 lines in your changes missing coverage. Please review.

Project coverage is 28.54%. Comparing base (5b59e82) to head (4143b1d).

Files Patch % Lines
front/src/common/api/generatedEditoastApi.ts 88.00% 24 Missing ⚠️
editoast/src/views/openapi.rs 99.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7686      +/-   ##
============================================
- Coverage     28.68%   28.54%   -0.14%     
  Complexity     2058     2058              
============================================
  Files          1249     1249              
  Lines        154451   154155     -296     
  Branches       3040     3040              
============================================
- Hits          44304    44004     -300     
- Misses       108334   108338       +4     
  Partials       1813     1813              
Flag Coverage Δ
core 75.01% <ø> (ø)
editoast 71.74% <99.33%> (-0.29%) ⬇️
front 10.00% <88.00%> (-0.02%) ⬇️
gateway 2.34% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 72.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leovalais leovalais force-pushed the lva/good-riddance branch 7 times, most recently from 7444bef to 7573f25 Compare June 11, 2024 15:41
@leovalais leovalais self-assigned this Jun 14, 2024
@leovalais leovalais force-pushed the lva/good-riddance branch 3 times, most recently from 96aa19d to d4e5bae Compare June 17, 2024 08:56
@leovalais leovalais force-pushed the lva/good-riddance branch from d4e5bae to fd5b2d1 Compare June 17, 2024 09:16
@leovalais leovalais requested a review from Uriel-Sautron June 17, 2024 09:17
@leovalais leovalais force-pushed the lva/good-riddance branch 2 times, most recently from d91598b to e5e77df Compare June 17, 2024 12:43
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, thank you !!!
LGTM, I only reviewed the front-end part.

@leovalais leovalais force-pushed the lva/good-riddance branch from e5e77df to 4143b1d Compare June 26, 2024 12:15
@leovalais leovalais marked this pull request as ready for review June 26, 2024 12:42
@leovalais leovalais requested review from a team as code owners June 26, 2024 12:43
Copy link
Contributor

@Tristramg Tristramg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn’t test it (my stack is currently a wreck), but it looks good to me. Congratulations!

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (reviewed + tested)

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm for front part

@leovalais leovalais added this pull request to the merge queue Jun 27, 2024
Merged via the queue into dev with commit c1a55f4 Jun 27, 2024
17 checks passed
@leovalais leovalais deleted the lva/good-riddance branch June 27, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants