-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bye bye openapi_legacy.yaml 🥳🥳 #7686
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7686 +/- ##
============================================
- Coverage 28.68% 28.54% -0.14%
Complexity 2058 2058
============================================
Files 1249 1249
Lines 154451 154155 -296
Branches 3040 3040
============================================
- Hits 44304 44004 -300
- Misses 108334 108338 +4
Partials 1813 1813
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7444bef
to
7573f25
Compare
96aa19d
to
d4e5bae
Compare
d4e5bae
to
fd5b2d1
Compare
d91598b
to
e5e77df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, thank you !!!
LGTM, I only reviewed the front-end part.
e5e77df
to
4143b1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn’t test it (my stack is currently a wreck), but it looks good to me. Congratulations!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (reviewed + tested)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm for front part
FINALLY