Add implementation for napi_add_finalizer #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a stopgap implementation that needs a more comprehensive implementation for all JS engines once this PR is merged. Tested manually with macOS with the following code: auto obj = Napi::ArrayBuffer::New(env, 1000000);
napi_add_finalizer(env, obj, const_cast<char*>("blah"), [](napi_env, void* finalize_data, void*) {
const char* message = static_cast<const char*>(finalize_data);
NSLog(@"napi_add_finalizer: callback: %s", message);
}, nullptr, nullptr); |
bghgary
added a commit
to BabylonJS/BabylonNative
that referenced
this pull request
Feb 5, 2024
See #1351. This a stopgap solution. Proper implementation needs to happen after BabylonJS/JsRuntimeHost#73 is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See BabylonJS/BabylonNative#1351