-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Node-API to latest from node.js #70
Conversation
Regarding performance with BabylonJS/BabylonNative#1350 I get 2.7 seconds before this update 2.9-3 seconds with. |
… into update_napi
It's actually not a good idea to update node-api without updating v8/jsc. So, it's better to mix #59 with this PR and changes in js_native_api_v8.cc are then not needed: v8 api is in sync with node-api. But there are issues:
But, there is this check in node-api:
|
@bghgary Same crash happens with or without the self-deleting weak reference. |
The crash I saw was because of async shaders. When running in release, everything is fine with Validation tests. Integration PR is here : BabylonJS/BabylonNative#1353 |
No description provided.