Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement napi_add_finalizer function #1351

Closed
mattbirman opened this issue Jan 31, 2024 · 1 comment
Closed

Implement napi_add_finalizer function #1351

mattbirman opened this issue Jan 31, 2024 · 1 comment
Assignees
@bghgary
Milestone
7.0

Comments

@mattbirman
Copy link

mattbirman commented Jan 31, 2024 •
edited
Loading

For questions, please use the forum.

Is your feature request related to a problem? Please describe.
We are using the napi Rust package and calling add_finalizer on JsObject. This call fails at runtime because napi_add_finalizer is not implemented in BabylonJS.

Describe the solution you'd like
An native implementation of napi_add_finalizer in BabylonJS.

Describe alternatives you've considered
No alternatives to this function. We have considered not adding the finalizer to the object and allowing the object to not be garbage-collected.

Additional context
N/A
@thomlucc thomlucc added this to the 7.0 milestone Jan 31, 2024
@bghgary bghgary mentioned this issue Feb 1, 2024
Merged
bghgary added a commit to BabylonJS/JsRuntimeHost that referenced this issue Feb 1, 2024
@bghgary
Add implementation for napi_add_finalizer (#73)
c147df4 
See BabylonJS/BabylonNative#1351
@bghgary bghgary mentioned this issue Feb 2, 2024
Merged
bghgary added a commit that referenced this issue Feb 5, 2024
@bghgary
Update JsRuntimeHost to pick up napi_add_finalizer for JSC (#1352)
234ac3b 
See #1351. This a stopgap solution. Proper implementation needs to
happen after BabylonJS/JsRuntimeHost#73 is
merged.
@CedricGuillemet
Copy link
Contributor

Can we close this issue @bghgary ?

@bghgary bghgary mentioned this issue Feb 9, 2024
Merged
bghgary added a commit that referenced this issue Feb 9, 2024
@bghgary
Update to latest JsRuntimeHost with exposed napi_add_finalizer (#1357)
b993260 
See #1351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bghgary bghgary

Labels
None yet
Projects
None yet
Milestone
7.0
Development

No branches or pull requests
4 participants
@CedricGuillemet @mattbirman @bghgary @thomlucc