Ensure recipient headers are shown in message list #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulipbot
added
size: S
preetmishra
approved these changes
May 25, 2020
There was a problem hiding this comment.
@neiljp Thanks for pushing a fix. This seems to work as expected and the changes look good to me. 👍
Update: I ran the changes locally for manual testing.
To see the difference, I replaced the text, that goes in the title, with a very long string (the Divider bar doesn't show up but I see you've mentioned that in the commit message). The spacing commit looks good as well.
However, there's a typo in the first commit message - 'previousely'. I missed it in the first pass.
This commit allows recipient headers to wrap onto multiple lines, rather than being a fixed width, which previously caused them to not be rendered in narrow windows. This at least shows the recipient header if they are long, however the styling could be improved. A custom urwid widget may be necessary to improve further. Fixes zulip#671.
This improves consistency between how private and stream message recipient headers are shown. For private messages, this avoids the space being spuriously highlighted (selected) when the message underneath is selected, as a separate space in the columns was not previously styled. For stream messages, this ensures that the stream/topic text is separated from the line/bar by a space, if it wraps onto a second line; previously the space was part of the stream/topic text. Tests amended.
neiljp
force-pushed
the
2020-05-23-ensure-recipients-shown
branch
from
df33751 to
a6c686b
Compare
|
@preetmishra Thanks for the review 👍 Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #671, which is reproducible by resizing the window to be very narrow and noting the 'blank' headers that appear where there is a change in recipients.
An additional commit is included, which improves the spacing between the header text and the new lines/bars, both fixing an existing bug (for PMs) and ensuring a space is shown in the narrow-window situation.