Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long message recipients are not shown in narrow windows #671

Closed
neiljp opened this issue May 25, 2020 · 1 comment · Fixed by #672
Closed

Long message recipients are not shown in narrow windows #671

neiljp opened this issue May 25, 2020 · 1 comment · Fixed by #672
Assignees
@neiljp
Labels
area: UI General user interface update bug Something isn't working in progress
Milestone
0.5.2

Comments

@neiljp
Copy link
Collaborator

neiljp commented May 25, 2020

This is most notable with many PM recipients or with long stream/topic names. The recipients are still shown in the 'current messages recipients' box, but not in the list of messages. This is troublesome in stream, all-pm and presumably all-message narrows, where these headings are relied upon to understand which messages are in which narrow, within a wider/broader narrow (eg. messages in a given topic, in the stream).
@neiljp neiljp added bug Something isn't working area: UI General user interface update labels May 25, 2020
@neiljp neiljp added this to the 0.5.2 milestone May 25, 2020
@neiljp neiljp self-assigned this May 25, 2020
@neiljp
Copy link
Collaborator Author

neiljp commented May 25, 2020

Note that this is visible not just in very-narrow windows - which may not be very common - but also with quite wide windows but with long stream/topic combinations or very long lists of PM names.

neiljp added a commit to neiljp/zulip-terminal that referenced this issue May 25, 2020
@neiljp
boxes: Pack recipient headers to ensure they are displayed.
f4bc7b5 
This commit allows recipient headers to wrap onto multiple lines, rather
than being a fixed width, which previousely caused them to not be
rendered in narrow windows.

This at least shows the recipient header if they are long, however the
styling could be improved. A custom urwid widget may be necessary to
improve further.

Fixes zulip#671.
@neiljp neiljp mentioned this issue May 25, 2020
Merged
neiljp added a commit to neiljp/zulip-terminal that referenced this issue May 26, 2020
@neiljp
boxes: Pack recipient headers to ensure they are displayed.
6ab45cc 
This commit allows recipient headers to wrap onto multiple lines, rather
than being a fixed width, which previously caused them to not be
rendered in narrow windows.

This at least shows the recipient header if they are long, however the
styling could be improved. A custom urwid widget may be necessary to
improve further.

Fixes zulip#671.
neiljp added a commit that referenced this issue May 27, 2020
@neiljp
boxes: Pack recipient headers to ensure they are displayed.
949e64d 
This commit allows recipient headers to wrap onto multiple lines, rather
than being a fixed width, which previously caused them to not be
rendered in narrow windows.

This at least shows the recipient header if they are long, however the
styling could be improved. A custom urwid widget may be necessary to
improve further.

Fixes #671.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neiljp neiljp

Labels
area: UI General user interface update bug Something isn't working in progress
Projects
None yet
Milestone
0.5.2
Development

Successfully merging a pull request may close this issue.

Ensure recipient headers are shown in message list neiljp/zulip-terminal
2 participants
@neiljp @zulipbot