Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup dependencies #291

Merged
merged 6 commits into from
Sep 21, 2021
Merged

Cleanup dependencies #291

merged 6 commits into from
Sep 21, 2021

Conversation

pablopalacios
Copy link
Contributor

  • remove lodash
  • remove coveralls
  • replace body-parser with express.json
  • replace istanbul with nyc

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@pablopalacios pablopalacios force-pushed the ci-tests branch 3 times, most recently from 946725e to 4713036 Compare September 19, 2021 21:15
@pablopalacios pablopalacios marked this pull request as ready for review September 19, 2021 21:20
@pablopalacios pablopalacios changed the title cleanup dependencies Cleanup dependencies Sep 19, 2021
@redonkulus
Copy link
Contributor

Just have to remove coveralls from the GitHub action too.

@pablopalacios
Copy link
Contributor Author

@redonkulus oh, I've just added it. But it seems that exactly right now, coveralls is under maintenance.

@redonkulus
Copy link
Contributor

I dont think coveralls is working, I would just remove coveralls all together, its not really beneficial.

@pablopalacios
Copy link
Contributor Author

@redonkulus I also removed the dependency on qs.

Copy link
Contributor

@redonkulus redonkulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@redonkulus redonkulus merged commit a5d5c5b into yahoo:master Sep 21, 2021
@pablopalacios pablopalacios deleted the ci-tests branch September 21, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants