package.json: remove qs as dev dependency

yahoo · Sep 20, 2021 · 6c382b8 · 6c382b8
1 parent 481a729
commit 6c382b8
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 13 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -39,7 +39,6 @@
     "pre-commit": "^1.0.0",
     "prettier": "^2.3.2",
     "puppeteer": "^10.2.0",
-    "qs": "^6.7.0",
     "sinon": "^11.1.1",
     "supertest": "^6.0.0",
     "webpack": "^5.51.1"

diff --git a/tests/unit/libs/fetcher.client.js b/tests/unit/libs/fetcher.client.js
@@ -7,7 +7,6 @@
 
 var expect = require('chai').expect;
 var mockery = require('mockery');
-var qs = require('qs');
 var sinon = require('sinon');
 var supertest = require('supertest');
 var xhr = require('xhr');
@@ -17,6 +16,7 @@ FakeXMLHttpRequest.onCreate = handleFakeXhr;
 xhr.XMLHttpRequest = FakeXMLHttpRequest;
 
 var Fetcher = require('../../../libs/fetcher.client');
+var defaultConstructGetUri = require('../../../libs/util/defaultConstructGetUri');
 var REST = require('../../../libs/util/http.client');
 var testCrud = require('../../util/testCrud');
 var defaultOptions = require('../../util/defaultOptions');
@@ -122,13 +122,8 @@ describe('Client Fetcher', function () {
             validateXhr = null;
         });
     });
+
     describe('CORS', function () {
-        function constructGetUri(uri, resource, params, config, context) {
-            params = Object.assign(context, params);
-            if (config.cors) {
-                return uri + '/' + resource + '?' + qs.stringify(params);
-            }
-        }
         before(function () {
             validateXhr = function (req) {
                 if (req.method === 'GET') {
@@ -149,10 +144,7 @@ describe('Client Fetcher', function () {
         testCrud({
             params: params,
             body: body,
-            config: {
-                cors: true,
-                constructGetUri: constructGetUri,
-            },
+            config: { cors: true },
             disableNoConfigTests: true,
             callback: callback,
             resolve: resolve,
@@ -381,6 +373,28 @@ describe('Client Fetcher', function () {
         });
     });
 
+    describe('Custom constructGetUri', () => {
+        it('is called correctly', () => {
+            const fetcher = new Fetcher({});
+            const constructGetUri = sinon
+                .stub()
+                .callsFake(defaultConstructGetUri);
+
+            return fetcher
+                .read('mock_service', { foo: 'bar' }, { constructGetUri })
+                .then(() => {
+                    sinon.assert.calledOnceWithExactly(
+                        constructGetUri,
+                        '/api',
+                        'mock_service',
+                        { foo: 'bar' },
+                        { constructGetUri },
+                        {}
+                    );
+                });
+        });
+    });
+
     describe('Custom request headers', function () {
         var VERSION = '1.0.0';