Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace dependencies #2381

Merged
merged 7 commits into from
Oct 30, 2023
Merged

Conversation

marc0246
Copy link
Contributor

This makes all our dependencies be specified using workspace dependencies, so that they're all in one place and easier to maintain. In particular, it's easy to see at a glance what might need updating or what could be removed, and having multiple versions of the same dependency is less likely to occur. Also, since our own public crates are also workspace dependencies, it's also more convenient to bump their versions since they're all in the same place.

I made examples its own workspace for two reasons:

  • It has different and more dependencies than the rest of the repo.
    • It didn't feel right putting dependencies like winit, png, rand, etc. in the root workspace's manifest.
    • The examples need vulkano with default features, while the root crates need it without.
  • I'm always forced to remove the examples from the workspace when I checkout a new branch, because otherwise rust-analyzer chokes for a solid minute on each save, rendering my computer unusable in the meantime. A nice side-effect of this change is that since the examples aren't part of the root workspace anymore, rust-analyzer won't check them unless you enter their workspace.

I updated the CI to account for the two workspaces.

@marc0246
Copy link
Contributor Author

I added a workspace version as well, so that everything is in one place and bumping the version is more streamlined.

@marc0246
Copy link
Contributor Author

I removed the workspace-level package version again because it's a bit inconvenient in the case when one only needs to bump the patch versions of certain packages.

@AustinJ235 AustinJ235 merged commit 1e91287 into vulkano-rs:master Oct 30, 2023
@marc0246 marc0246 deleted the workspace-dependencies branch October 30, 2023 03:42
This was referenced Oct 30, 2023
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
* Use workspace dependencies

* Update CI workflow to account for the two workspaces

* Make the tables in the root workspace a bit nicer to look at

* Use workspace package version

* Remove workspace package version

* Make winit a workspace dependency as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants