Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.34.x winit 0.29 #2376

Closed
wants to merge 2 commits into from
Closed

0.34.x winit 0.29 #2376

wants to merge 2 commits into from

Conversation

hyultis
Copy link

@hyultis hyultis commented Oct 29, 2023

  1. Update documentation to reflect any user-facing changes - in this repository.

  2. Make sure that the changes are covered by unit-tests.

  3. [ x ] Run cargo fmt on the changes.

  4. [ x ] Please put changelog entries in the description of this Pull Request
    if knowledge of this change could be valuable to users. No need to put the
    entries to the changelog directly, they will be transferred to the changelog
    file by maintainers right after the Pull Request merge.

    Please remove any items from the template below that are not applicable.

  5. [ x ] Describe in common words what is the purpose of this change, related
    Github Issues, and highlight important implementation aspects.

Hello,

This update winit dependency of vulkano-win, i have updated all version of winit_to_surface(), i have tested android, vulkan/x11, win32 (via wine).

Not tested macos/ios.

Changelog:

### Public dependency updates
- [winit](https://crates.io/crates/winit) 0.29.3

@marc0246
Copy link
Contributor

Hello, and thank you for the work. Please note that vulkano-win is deprecated. Are you aware of this?

@hyultis
Copy link
Author

hyultis commented Oct 29, 2023

oh, i have not see that, thank

@marc0246
Copy link
Contributor

I updated our examples to winit 0.29 in #2385 so you can see how it can be done. Specifically this commit shows you how you can use winit 0.29 together with vulkano 0.34.

As for this PR, I'm really sorry but I will be closing it, as much as I hate to because I know you put work into it. I added a note in #2381 for the future. Future contributions are always welcome. :)

As an aside, if you ever have trouble with vulkano, we have a #support channel on our discord. Or you can open an issue.

@marc0246 marc0246 closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants