Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ability to release as @next from master #2894

Closed
wants to merge 2 commits into from

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Dec 7, 2015

Here's the output of contrib release next minor:

$ contrib release next minor --dry-run

DRY RUN OF release next minor

STEP 1. Ensure there's no unadded changes
$ git diff --exit-code

STEP 2. Ensure there's no uncommitted changes
$ git diff --cached --exit-code

STEP 3. Switch to the development branch
$ git checkout master

STEP 4. Get any changes to master in the main project
$ git pull upstream master

STEP 5. Create a temporary branch for the dist
$ git checkout -b temp-release-branch master

STEP 6. Bump package versions
$ grunt version:{{release_type}}

STEP 7 (ID: version). Return the current VJS Version from the package.json file
$ ./build/bin/version

STEP 8. Add and commit the package changes
$ git commit -am 'v{{version}}'

STEP 9. Checkout the developmet branch
$ git checkout master

STEP 10. Merge package changes into the dev brach
$ git merge temp-release-branch

STEP 11. Push the dev branch changes to the repo
$ git push upstream master

STEP 12. Checkout the temp branch again
$ git checkout temp-release-branch

STEP 13. Build the dist
$ grunt dist

STEP 14. Add the (otherwise ignored) release files
$ git add dist --force

STEP 15. Commit the dist changes
$ git commit -m 'v{{version}} dist'

STEP 16. Tag the release
$ git tag -a v{{version}} -m 'v{{version}}'

STEP 17. Push the new tag to the repo
$ git push upstream --tags

STEP 18. Publish to npm as 'next'
$ npm publish --tag next

STEP 19. Checkout the developmet branch
$ git checkout master

STEP 20. Delete the temp release branch
$ git branch -D temp-release-branch


IT'S OVER!

Fixes #2868

"steps": [{ "include": "release run_next" }]
}
},

"prerelease": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically, what used to be under prerelease was moved into run_next, then prelease and next {patch, minor, major} use run_next which just picks up the appropriate release_type.

@gkatsev gkatsev mentioned this pull request Dec 7, 2015
7 tasks
@gkatsev gkatsev added the needs: LGTM Needs one or more additional approvals label Dec 7, 2015
@gkatsev gkatsev added the minor This PR can be added to a minor release. It should not be added to a patch release. label Dec 8, 2015
@misteroneill
Copy link
Member

LGTM

1 similar comment
@dmlap
Copy link
Member

dmlap commented Dec 8, 2015

LGTM

@gkatsev gkatsev closed this in 44edb12 Dec 8, 2015
@gkatsev gkatsev deleted the contrib-updates branch December 8, 2015 18:55
jgubman added a commit to jgubman/video.js that referenced this pull request Jan 27, 2016
* upstream/stable: (479 commits)
  v5.4.4
  @gkatsev switched to use custom vtt.js from npm. closes videojs#2905
  v5.4.3
  @gkatsev updated options customizer and github-release options. closes videojs#2903
  v5.4.2
  @gkatsev updated grunt-release config. closes videojs#2900
  v5.4.1
  @gkatsev added chg- and github- release for next releases. closes videojs#2899
  v5.4.0
  @gkatsev added ability to release next tag from master. closes videojs#2894
  @gkatsev added nullcheck for cues in updateForTrack. Fixes videojs#2870. closes videojs#2896
  @chemoish emulated HTMLTrackElement to enable track load events. closes videojs#2804
  @gkatsev added a Player#reset method. Fixes videojs#2852. closes videojs#2880
  @nick11703 changed multiline comments in sass with single-line comments. closes videojs#2827
  @gkatsev added Player#tech. Fixes videojs#2617. closes videojs#2883
  @misteroneill updated videojs-ie8 to 1.1.1. closes videojs#2869
  v5.3.0
  @imbcmdth added sourceOrder option for source-first ordering in selectSource. closes videojs#2847
  @forbesjo updated formatTime to not go negative. closes videojs#2821
  v5.2.4
  ...
@gkatsev gkatsev removed the needs: LGTM Needs one or more additional approvals label Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor This PR can be added to a minor release. It should not be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rework prerelease process
3 participants