Add Player#reset function. #2880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @method reset | ||
| */ | ||
| reset() { | ||
| this.loadTech_('Html5', null); |
There was a problem hiding this comment.
Switch to the Html5 tech. Passing in null for source in loadTech_ would load the tech in "late init" mode if it needed to switch from another tech.
There was a problem hiding this comment.
Should this switch to the first tech in the tech order?
There was a problem hiding this comment.
I was debating that but
- we would need to implement something for flash in this case and probably would need to modify the swf
- Setting a source should choose the appropriate tech after the reset
- Html5 is basically the default tech.
Switching to Html5 and then resetting it is probably the easiest way to get to a nice base state where no sources are loaded and all readyStates are reset.
gkatsev
added
minor
| el.removeAttribute('src'); | ||
|
|
||
| if (typeof el.load === 'function') { | ||
| // wrapping in an iife so it's not deoptimized (#1060#discussion_r10324473) |
There was a problem hiding this comment.
I would be surprised if this was called frequently enough where de-opt was a performance issue but it's fine to leave this way, too.
|
Looks like I need to rebase this. |
Reset loads in the html5 tech and then resets the media element via a tech call. A techCall was used so that other techs could implement reset functionality as well and we could theoretically not switch to the Html5 tech on reset.
|
Rebased. |
| @@ -86,6 +86,9 @@ class Html5 extends Tech { | |||
|
|
|||
| this.triggerReady(); | |||
| } | |||
| clearMedia() { | |||
|
LGTM |
jgubman
added a commit
to jgubman/video.js
that referenced
this pull request
Jan 27, 2016
* upstream/stable: (479 commits) v5.4.4 @gkatsev switched to use custom vtt.js from npm. closes videojs#2905 v5.4.3 @gkatsev updated options customizer and github-release options. closes videojs#2903 v5.4.2 @gkatsev updated grunt-release config. closes videojs#2900 v5.4.1 @gkatsev added chg- and github- release for next releases. closes videojs#2899 v5.4.0 @gkatsev added ability to release next tag from master. closes videojs#2894 @gkatsev added nullcheck for cues in updateForTrack. Fixes videojs#2870. closes videojs#2896 @chemoish emulated HTMLTrackElement to enable track load events. closes videojs#2804 @gkatsev added a Player#reset method. Fixes videojs#2852. closes videojs#2880 @nick11703 changed multiline comments in sass with single-line comments. closes videojs#2827 @gkatsev added Player#tech. Fixes videojs#2617. closes videojs#2883 @misteroneill updated videojs-ie8 to 1.1.1. closes videojs#2869 v5.3.0 @imbcmdth added sourceOrder option for source-first ordering in selectSource. closes videojs#2847 @forbesjo updated formatTime to not go negative. closes videojs#2821 v5.2.4 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset loads in the html5 tech and then resets the media element via a
tech call.
A techCall was used so that other techs could implement reset
functionality as well and we could theoretically not switch to the Html5
tech on reset.
Fixes #2852