Excessive newlines in head block overriden from decorator #92

Stummi · 2016-01-08T13:29:14Z

I noticed that, when using a decorator and overriding the head block to add resources, there are excessive newlines in the result.

I reduced the issue to a minimal example here:

Layout:

<!DOCTYPE html>
<html xmlns:th="http://www.thymeleaf.org"
    xmlns:layout="http://www.ultraq.net.nz/web/thymeleaf/layout">
<head>
    <title>Layout</title>
</head>
<body></body>
</html>

Template

<!DOCTYPE html>
<html xmlns:th="http://www.thymeleaf.org"
    xmlns:layout="http://www.ultraq.net.nz/web/thymeleaf/layout"
    layout:decorator="layout">
<head>
    <title>Test</title>
    <link rel="stylesheet" href="/css/foo.css" />
    <link rel="stylesheet" href="/css/bar.css" />
</head>
<body></body>
</html>

Creates the following result:

<!DOCTYPE html>

<html>
<head>
    <title>Test</title>
    <link rel="stylesheet" href="/css/foo.css" />
    <link rel="stylesheet" href="/css/bar.css" />






</head>
<body></body>
</html>

It seems that three empty lines are created for every line added to the head block.

The official example, shows the same issue for me:

<!DOCTYPE html>

<html>
  <head>
    <title>Content page 1</title>
    <script src="common-script.js"></script>
    <script src="content-script.js"></script>




  </head>
  <body>
    <header>
      <h1>My website</h1>
    </header>
    <section>
      <p>This is a paragraph from content page 1</p>
    </section>
    <footer>
      <p>My footer</p>
      <p>This is some footer content from content page 1</p>
    </footer>  
  </body>
</html>

Using thymeleaf 2.1.4.RELEASE and thymeleaf-layout-dialect 1.3.1

Stummi · 2016-01-08T14:28:10Z

Additional note: While playing around with the versions, it seems that this issue was introduced with version 1.2.9

ultraq · 2016-02-17T10:14:10Z

Just had a look into this, and I'm seeing a lot of extra whitespace coming from when I copy over whitespace nodes from the content template into the decorator one. This is during the <head> merging process. /~https://github.com/ultraq/thymeleaf-layout-dialect/blob/master/Source/nz/net/ultraq/thymeleaf/decorators/html/HtmlHeadDecorator.groovy#L101-L105

In versions prior to when this is seen, I copied only other elements. But for work done in issue #70 (released in 1.2.9), I relaxed that and copied over everything.

I might need to add some smarts to exclude copying over whitespace into whitespace, because then it just compounds, leading to this issue.

ultraq · 2016-02-18T09:16:13Z

Compounding whitespace fixed!

This issue affected anybody using the default 'appending' head merging strategy. If you configured Thymeleaf to use the grouping strategy or implemented your own, you'd likely not encounter this issue.

I've released a 1.3.3-SNAPSHOT version with this fix in the interim.

ultraq added the enhancement label Jan 9, 2016

ultraq self-assigned this Feb 9, 2016

ultraq added a commit that referenced this issue Feb 17, 2016

Fix for #92, don't copy collapsible whitespace during <head> merging

24cf23c

ultraq added bug and removed enhancement labels Feb 18, 2016

ultraq closed this as completed Feb 18, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Excessive newlines in head block overriden from decorator #92

Excessive newlines in head block overriden from decorator #92

Stummi commented Jan 8, 2016

Stummi commented Jan 8, 2016

ultraq commented Feb 17, 2016

ultraq commented Feb 18, 2016

Excessive newlines in head block overriden from decorator #92

Excessive newlines in head block overriden from decorator #92

Comments

Stummi commented Jan 8, 2016

Stummi commented Jan 8, 2016

ultraq commented Feb 17, 2016

ultraq commented Feb 18, 2016