Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Head merge drops conditional comments. #70

Closed
stoye opened this issue Apr 23, 2015 · 6 comments
Closed

Head merge drops conditional comments. #70

stoye opened this issue Apr 23, 2015 · 6 comments
Assignees
Labels

Comments

@stoye
Copy link

stoye commented Apr 23, 2015

We have a responsive_layount.html template that acts as our base template for everything. We have several templates that get merged into this one that have conditional comments for things like respond.js and other IE8 fixes. When we include these in the responsive_layout file, everything's fine, but if we include them in the other templates (that get merged with responsive_layout), they get blown out, and never get served.

@ultraq ultraq added the bug label Apr 23, 2015
@ultraq ultraq self-assigned this Apr 23, 2015
ultraq added a commit that referenced this issue Apr 24, 2015
@ultraq ultraq closed this as completed in fdcf037 Apr 24, 2015
@ultraq
Copy link
Owner

ultraq commented Apr 24, 2015

Hi there @stoye, I've created a test case and fix for the issue you described, and uploaded a 1.2.9-SNAPSHOT version of the layout dialect to Maven with this fix. Could you give that version a try, see if it works for you?

ultraq added a commit that referenced this issue Apr 25, 2015
ultraq added a commit that referenced this issue Apr 25, 2015
@stoye
Copy link
Author

stoye commented Jun 23, 2015

Hey there,

Sorry for the crazy late reply. This fell off our radar for a while. It seems to work marvelously (and thanks for keeping the SNAPSHOT up). I'll keep an eye out for when this gets released as a bugfix, I really appreciate it.

@stoye
Copy link
Author

stoye commented Jun 23, 2015

So it turns out this is a pretty big blocker for us. Any opportunity for this getting rolled into a release rather quickly would be greatly appreciated!!

@ultraq
Copy link
Owner

ultraq commented Jun 23, 2015

Happy to make a 1.2.9 release with just this fix in it when I get home tonight (dunno which timezone you're in, but for me that'll be about 12 hours from the posting of this message. I'll see if I can't kick that off earlier given Maven's delay on releasing new uploads).

@ultraq
Copy link
Owner

ultraq commented Jun 24, 2015

And the 1.2.9 release is now live. The Maven version is now making its way through the automated release process, but should show up in the next few hours.

@stoye
Copy link
Author

stoye commented Jun 24, 2015

Awesome, thanks so much! Working perfectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants