v4: Card improvements #19885
Merged
v4: Card improvements #19885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove the box-shadow and switch back to border to match .card basics - Update the header nav margin override--since we restored the border, we need that default negative margin at the bottom
- Remove background-color from header and footer in inverse cards (fixes #19841) - Update border override for header and footer in cards; only need to declare a new color - Update the selector for targetting blockquote footers in cards
…lways the same width
Here we're doing some margin swapping, so it looks a little funky. All this does is match the margin implementation and rendering across our table and flex versions of card decks.
This was referenced May 12, 2016
This was referenced May 12, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP.
17911: Explicitly remove margin-bottom from cards in
.card-deck.Here we're doing some margin swapping, so it looks a little funky. All this does is match the margin implementation and rendering across our table and flex versions of card decks.
17959, Cards in .card-deck do not always have same width #19650: Improve non-flexbox card deck behavior so columns are always the same width.
19840: Invert the
.card-subtitlecolor as well for.card-inverse.Update card variants:
Update card header and footer
box-shadowand switch back to border to match.cardbasics