Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Card-Deck class set card margin bottom to 0 #17911

Closed
gotoGosub opened this issue Oct 13, 2015 · 2 comments
Closed

Card-Deck class set card margin bottom to 0 #17911

gotoGosub opened this issue Oct 13, 2015 · 2 comments
Labels
css v4
Milestone
v4.0.0-alpha.3

Comments

@gotoGosub
Copy link

It seems that the card-deck class has impact on margin bottom of card class. I can correctly see 0.75rem in browser page inspection, but margin is then rendered at 0px. Altering the margin bottom height to other values has no effect. The result on page is no margin is present between card-deck-wrapper -> card-deck -> card and subsequent elements.
@mdo
Copy link
Member

mdo commented Dec 8, 2015

By default the .card-deck nullifies a .card's bottom margin because of the table styles. Doesn't happen with the flex approach I imagine. Probably just need to nuke the bottom margin entirely and use spacer utils instead.

@mdo mdo mentioned this issue Dec 8, 2015
Closed
8 tasks
@mdo mdo added this to the v4.0.0-alpha.3 milestone May 12, 2016
mdo added a commit that referenced this issue May 12, 2016
@mdo
Fixes #17911: Explicitly remove margin-bottom from cards in .card-deck
56a5b19 
Here we're doing some margin swapping, so it looks a little funky. All this does is match the margin implementation and rendering across our table and flex versions of card decks.
@mdo mdo mentioned this issue May 12, 2016
Merged
@mdo
Copy link
Member

mdo commented May 12, 2016

Improvements coming in #19885.

@mdo mdo closed this as completed May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css v4
Projects
None yet
Milestone
v4.0.0-alpha.3
Development

No branches or pull requests
3 participants
@mdo @cvrebert @gotoGosub