Skip to content
This repository has been archived by the owner on Feb 26, 2019. It is now read-only.

godep v77 breaks with "is not using a known version control system" #531

Closed
stevenh opened this issue Jan 22, 2017 · 6 comments
Closed

godep v77 breaks with "is not using a known version control system" #531

stevenh opened this issue Jan 22, 2017 · 6 comments

Comments

@stevenh
Copy link

stevenh commented Jan 22, 2017

Expected behaviour

godep save ./... should work

Actual behaviour

godep: error while inspecting "/data/go/src/github.com": directory "/data/go/src/github.com" is not using a known version control system

Please note that the actual package directories are using known version control systems (git) but the intermediate directories are obviously not part of any repo.

Steps to reproduce behaviour

run godep save ./... with a directory in the GOPATH that isn't part of a known version control system.

This works fine in v74 and v76.

godep version output

godep v77 (freebsd/amd64/go1.7.4

go version output

go version go1.7.4 freebsd/amd64

@freeformz
Copy link

It may be huge, but can you provide the output of godep save -d -v ./... &> output ?

@xrl
Copy link

xrl commented Jan 23, 2017

@freeformz I have a similar issue. I'm new to the kubernetes project (as well as godep). Here's what I got: https://gist.github.com/xrl/080e18909538e9d748eb87cd5d58c7ae . Downgrading to v74 got me going again.

@freeformz
Copy link

It looks like the change to stop using build.ImportDir in the code that handles './...' and the like is returning stuff above the current directory. There probably aren't tests for that specific issue, but I expected the existing tests to cover them. I'll have to dig more to figure out why.

@AlmogBaku
Copy link

same here

@turtlemonvh
Copy link

turtlemonvh commented Feb 1, 2017

Temporary solution

go get gopkg.in/tools/godep.v76 && \cp $GOPATH/bin/godep.v76 $GOPATH/bin/godep

@freeformz
Copy link

Fixed. Sorry about that. Silly mistake. :-(

viovanov pushed a commit to cloudfoundry-incubator/fissile that referenced this issue Mar 15, 2017
Note that this rolls back to godeps v76 due to
tools/godep#531

This also explicitly pulls in github.com/ugorji/go/codec otherwise we
get odd errors from k8s client
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants