Record error from fillPackage

Fixes #531

Changelog.md

@@ -1,3 +1,7 @@
+#v79 (2017/02/01)
+
+* Fixes #531: fullPackageInDir didn't capture the error from fillPackage()
+
 #v78 (2017/01/19)
 
 * Don't use build.ImportDir when discovering packages for the package spec. Fixes #529

list.go

@@ -98,7 +98,7 @@ func fullPackageInDir(dir string) (*build.Package, error) {
 		if pkg.Goroot {
 			pkg, err = build.ImportDir(pkg.Dir, 0)
 		} else {
-			fillPackage(pkg)
+			err = fillPackage(pkg)
 		}
 		if err == nil {
 			pkgCache[dir] = pkg

save_test.go

@@ -1538,6 +1538,41 @@ func TestSave(t *testing.T) {
 				},
 			},
 		},
+		{ // 39 - return errors from fillPackage: #531
+			cwd:    "C",
+			args:   []string{"./..."},
+			vendor: true,
+			start: []*node{
+				{
+					"C",
+					"",
+					[]*node{
+						{"C.go", pkg("C", "github.com/D"), nil},
+						{"vendor/github.com/D/D.go", pkg("D"), nil},
+						{"+git", "C1", nil},
+					},
+				},
+				{
+					"github.com/D",
+					"",
+					[]*node{
+						{"D.go", pkg("D"), nil},
+						{"+git", "D1", nil},
+					},
+				},
+			},
+			want: []*node{
+				{"C/C.go", pkg("C", "github.com/D"), nil},
+				{"C/vendor/github.com/D/D.go", pkg("D"), nil},
+			},
+			wdep: Godeps{
+				ImportPath: "C",
+				Packages:   []string{"./..."},
+				Deps: []Dependency{
+					{ImportPath: "github.com/D", Comment: "D1"},
+				},
+			},
+		},
 	}
 
 	wd, err := os.Getwd()

version.go

@@ -8,7 +8,7 @@ import (
 	"strings"
 )
 
-const version = 78
+const version = 79
 
 var cmdVersion = &Command{
 	Name:  "version",