Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divert linear regressions with poisson family to poisson_reg() #1219

Merged
merged 8 commits into from
Jan 29, 2025

Conversation

topepo
Copy link
Member

@topepo topepo commented Nov 13, 2024

Motivated by tidymodels/tune#956

There are so many ways people can pass the family to glm() and glmnet(). This checks for all four methods that I'm aware of.

@topepo topepo marked this pull request as ready for review November 13, 2024 22:05
@topepo topepo requested a review from hfrick November 13, 2024 22:05
Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! For your consideration but not a request: Would it make sense to move those checks to check_args.linear_reg() or would checks on engine args in addition to main args mess with anything else?

@topepo topepo merged commit 53263e9 into main Jan 29, 2025
10 checks passed
@topepo topepo deleted the poisson-linear-reg branch January 29, 2025 17:58
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants