Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transition to vec_slice() in get_pkgs() #956

Merged
merged 1 commit into from
May 3, 2023
Merged

Conversation

simonpcouch
Copy link
Contributor

With main dev:

library(tidymodels)
  
set.seed(1)

bench::mark(
  old = 
    fit_resamples(
      linear_reg(),
      mpg ~ .,
      bootstraps(mtcars)
    )
)
#> # A tibble: 1 × 6
#>   expression      min   median `itr/sec` mem_alloc `gc/sec`
#>   <bch:expr> <bch:tm> <bch:tm>     <dbl> <bch:byt>    <dbl>
#> 1 old           210ms    213ms      4.61    14.2MB     7.68

With this PR:

#> # A tibble: 1 × 6
#>   expression      min   median `itr/sec` mem_alloc `gc/sec`
#>   <bch:expr> <bch:tm> <bch:tm>     <dbl> <bch:byt>    <dbl>
#> 1 new           201ms    204ms      4.77    14.1MB     7.96

Created on 2023-05-01 with reprex v2.0.2

@simonpcouch simonpcouch requested a review from EmilHvitfeldt May 1, 2023 19:06
Copy link
Member

@EmilHvitfeldt EmilHvitfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

@simonpcouch simonpcouch merged commit 17d57a2 into main May 3, 2023
@simonpcouch simonpcouch deleted the speedup-get-pkgs branch May 3, 2023 13:17
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants