Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove autoprefixer #1749

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Conversation

EWright212
Copy link
Contributor

Removed auto-prefixer gem as it has been deprecated. Tested on latest versions of Chrome, Firefox and IE with no adverse impact noted.

Copy link
Collaborator

@pablobm pablobm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a surface look. I seems to me that most of the prefixes come from third-party libraries: normalize.css, selectize, and the datetime picker. These come with prefixed CSS already (I think).

The few instances where our own CSS is autoprefixed, it appears to be for very obscure and specialised properties and selectors. This is a list after some grepping:

  -webkit-appearance: none;
     -moz-appearance: none;
[type="color"]::-moz-placeholder, [type="date"]::-moz-placeholder, [type="datetime-local"]::-moz-placeholder, [type="email"]::-moz-placeholder, [type="month"]::-moz-placeholder, [type="number"]::-moz-placeholder, [type="password"]::-moz-placeholder, [type="search"]::-moz-placeholder, [type="tel"]::-moz-placeholder, [type="text"]::-moz-placeholder, [type="time"]::-moz-placeholder, [type="url"]::-moz-placeholder, [type="week"]::-moz-placeholder, input:not([type])::-moz-placeholder, textarea::-moz-placeholder {
[type="color"]:-ms-input-placeholder, [type="date"]:-ms-input-placeholder, [type="datetime-local"]:-ms-input-placeholder, [type="email"]:-ms-input-placeholder, [type="month"]:-ms-input-placeholder, [type="number"]:-ms-input-placeholder, [type="password"]:-ms-input-placeholder, [type="search"]:-ms-input-placeholder, [type="tel"]:-ms-input-placeholder, [type="text"]:-ms-input-placeholder, [type="time"]:-ms-input-placeholder, [type="url"]:-ms-input-placeholder, [type="week"]:-ms-input-placeholder, input:not([type]):-ms-input-placeholder, textarea:-ms-input-placeholder {
[type="color"]::-ms-input-placeholder, [type="date"]::-ms-input-placeholder, [type="datetime-local"]::-ms-input-placeholder, [type="email"]::-ms-input-placeholder, [type="month"]::-ms-input-placeholder, [type="number"]::-ms-input-placeholder, [type="password"]::-ms-input-placeholder, [type="search"]::-ms-input-placeholder, [type="tel"]::-ms-input-placeholder, [type="text"]::-ms-input-placeholder, [type="time"]::-ms-input-placeholder, [type="url"]::-ms-input-placeholder, [type="week"]::-ms-input-placeholder, input:not([type])::-ms-input-placeholder, textarea::-ms-input-placeholder {
  -webkit-font-kerning: normal;
  -webkit-text-decoration-skip: ink;
  -webkit-appearance: none;
     -moz-appearance: none;
  -webkit-font-smoothing: antialiased;
  -webkit-user-select: none;
     -moz-user-select: none;
      -ms-user-select: none;

I think we can do without them.

@pablobm
Copy link
Collaborator

pablobm commented Aug 31, 2020

Actually, can you also remove this file please? spec/example_app/browserslist I think it's configuration for autoprefixer.

@pablobm
Copy link
Collaborator

pablobm commented Sep 10, 2020

And another thing: could you please rebase/squash the commits into a single commit?

* Autoprefixer was deprecated on 2020-08-03, but later undeprecated,
* But we don't need it for anything important in our CSS.

Closes thoughtbot#1733

Co-authored-by: Kehinde Olofinmoyin <Kehindeolofinmoyin@hotmail.com>
@nickcharlton
Copy link
Member

I just did this as @EWright212 is starting her new job! Woo!

I'll merge it now.

@nickcharlton nickcharlton merged commit 5d2dd7d into thoughtbot:master Sep 17, 2020
nickcharlton added a commit that referenced this pull request Sep 18, 2020
In #1749, we removed `autoprefixer-rails` from the usual `Gemfile` but it
didn't get removed from the `gemspec`.
nickcharlton added a commit that referenced this pull request Sep 21, 2020
In #1749, we removed `autoprefixer-rails` from the usual `Gemfile` but it
didn't get removed from the `gemspec`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants