-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove autoprefixer #1749
Remove autoprefixer #1749
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a surface look. I seems to me that most of the prefixes come from third-party libraries: normalize.css, selectize, and the datetime picker. These come with prefixed CSS already (I think).
The few instances where our own CSS is autoprefixed, it appears to be for very obscure and specialised properties and selectors. This is a list after some grepping:
-webkit-appearance: none;
-moz-appearance: none;
[type="color"]::-moz-placeholder, [type="date"]::-moz-placeholder, [type="datetime-local"]::-moz-placeholder, [type="email"]::-moz-placeholder, [type="month"]::-moz-placeholder, [type="number"]::-moz-placeholder, [type="password"]::-moz-placeholder, [type="search"]::-moz-placeholder, [type="tel"]::-moz-placeholder, [type="text"]::-moz-placeholder, [type="time"]::-moz-placeholder, [type="url"]::-moz-placeholder, [type="week"]::-moz-placeholder, input:not([type])::-moz-placeholder, textarea::-moz-placeholder {
[type="color"]:-ms-input-placeholder, [type="date"]:-ms-input-placeholder, [type="datetime-local"]:-ms-input-placeholder, [type="email"]:-ms-input-placeholder, [type="month"]:-ms-input-placeholder, [type="number"]:-ms-input-placeholder, [type="password"]:-ms-input-placeholder, [type="search"]:-ms-input-placeholder, [type="tel"]:-ms-input-placeholder, [type="text"]:-ms-input-placeholder, [type="time"]:-ms-input-placeholder, [type="url"]:-ms-input-placeholder, [type="week"]:-ms-input-placeholder, input:not([type]):-ms-input-placeholder, textarea:-ms-input-placeholder {
[type="color"]::-ms-input-placeholder, [type="date"]::-ms-input-placeholder, [type="datetime-local"]::-ms-input-placeholder, [type="email"]::-ms-input-placeholder, [type="month"]::-ms-input-placeholder, [type="number"]::-ms-input-placeholder, [type="password"]::-ms-input-placeholder, [type="search"]::-ms-input-placeholder, [type="tel"]::-ms-input-placeholder, [type="text"]::-ms-input-placeholder, [type="time"]::-ms-input-placeholder, [type="url"]::-ms-input-placeholder, [type="week"]::-ms-input-placeholder, input:not([type])::-ms-input-placeholder, textarea::-ms-input-placeholder {
-webkit-font-kerning: normal;
-webkit-text-decoration-skip: ink;
-webkit-appearance: none;
-moz-appearance: none;
-webkit-font-smoothing: antialiased;
-webkit-user-select: none;
-moz-user-select: none;
-ms-user-select: none;
I think we can do without them.
Actually, can you also remove this file please? |
And another thing: could you please rebase/squash the commits into a single commit? |
* Autoprefixer was deprecated on 2020-08-03, but later undeprecated, * But we don't need it for anything important in our CSS. Closes thoughtbot#1733 Co-authored-by: Kehinde Olofinmoyin <Kehindeolofinmoyin@hotmail.com>
1bbb14d
to
0aa02c7
Compare
I just did this as @EWright212 is starting her new job! Woo! I'll merge it now. |
In #1749, we removed `autoprefixer-rails` from the usual `Gemfile` but it didn't get removed from the `gemspec`.
In #1749, we removed `autoprefixer-rails` from the usual `Gemfile` but it didn't get removed from the `gemspec`.
Removed auto-prefixer gem as it has been deprecated. Tested on latest versions of Chrome, Firefox and IE with no adverse impact noted.