Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove autoprefixer-rails as a gem dependency #1772

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

nickcharlton
Copy link
Member

In #1749, we removed autoprefixer-rails from the usual Gemfile but it
didn't get removed from the gemspec.

In #1749, we removed `autoprefixer-rails` from the usual `Gemfile` but it
didn't get removed from the `gemspec`.
@dgmstuart
Copy link

@nickcharlton do you think this would resolve the Ruby 2.5 failure on my PR #1773, or is it something else?

Failure:
https://app.circleci.com/pipelines/github/thoughtbot/administrate/956/workflows/5cf2976f-fc78-410c-bc98-0de2ef5257fb/jobs/6869/parallel-runs/0/steps/0-110

@nickcharlton
Copy link
Member Author

Yeah, I'd imagine so. Because we've been trying to remove it I've not been paying attention to any environment problems.

@nickcharlton nickcharlton merged commit 55f6d35 into master Sep 21, 2020
@nickcharlton nickcharlton deleted the nc-remove-autoprefixer-as-a-gem-dependency branch September 21, 2020 11:25
@dgmstuart
Copy link

Yay it fixed it! 🎉
#1773 is now green.
Thanks @nickcharlton 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants