Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/**/*_test.ts files cause ts-node error in unit tests of packages that depend on tfjs #1380

Closed
caisq opened this issue Mar 14, 2019 · 0 comments
Closed

src/**/*_test.ts files cause ts-node error in unit tests of packages that depend on tfjs #1380

caisq opened this issue Mar 14, 2019 · 0 comments
Assignees
@nsthorat
Labels
type:bug Something isn't working

Comments

@caisq
Copy link
Contributor

caisq commented Mar 14, 2019

To get help from the community, we encourage using Stack Overflow and the tensorflow.js tag.

TensorFlow.js version

1.0.1

As a concrete example, see tensorflow/tfjs-models#171
We would have to add the /~https://github.com/tensorflow/tfjs-models/pull/171 patch command in order to prevent an error like the following:

yarn run v1.12.3
$ ts-node run_tests.ts
/usr/local/google/home/cais/tfjs/tfjs-models/speech-commands/node_modules/@tensorflow/tfjs-converter/src/executor/execution_context_test.ts:18
import {ExecutionContext} from './execution_context';
^^^^^^
@caisq caisq added the type:bug Something isn't working label Mar 14, 2019
@caisq caisq mentioned this issue Mar 14, 2019
Merged
@caisq caisq changed the title src/**/*_test.ts files cause tsc compilation errors in unit tests of packages that depend on tfjs src/**/*_test.ts files cause ts-node error in unit tests of packages that depend on tfjs Mar 14, 2019
caisq added a commit to tensorflow/tfjs-models that referenced this issue Mar 15, 2019
@caisq
[speech-commands] tfjs&tfjs-node --> v1.0.1; Work around import issue (…
e49adbe 
…#171)

- Remove the `rimraf node_modules/@tensorflow/tfjs-node` workaround for `yarn build` (see the fixed issue tensorflow/tfjs#1092)
- Add `rm $(find node_modules/@tensorflow -name *_test.ts)` workaround for `yarn test` (see new issue tensorflow/tfjs#1380)
This was referenced Mar 18, 2019
Merged
Merged
Merged
Merged
Merged
Merged
nsthorat pushed a commit to tensorflow/tfjs-core that referenced this issue Mar 18, 2019
Don't publish src/**/*_test.ts files on NPM. (#1631)
824d745 
There is no need to publish the src/**/*_test.ts files.

It causes the tests to execute in dependent packages when those tests are run. This also decreases the NPM package size.

See tensorflow/tfjs#1380

DEV
nsthorat pushed a commit to tensorflow/tfjs-layers that referenced this issue Mar 18, 2019
Don't publish _test.ts files on NPM. (#500)
7f45ae6 
DEV
There is no need to publish the src/**/*_test.ts files.

It causes the tests to execute in dependent packages when those tests are run. This also decreases the NPM package size.

See tensorflow/tfjs#1380
nsthorat pushed a commit to tensorflow/tfjs-data that referenced this issue Mar 18, 2019
Don't publish _test.ts files on NPM. (#164)
e3339fd 
There is no need to publish the src/**/*_test.ts files.

It causes the tests to execute in dependent packages when those tests are run. This also decreases the NPM package size.

See tensorflow/tfjs#1380

DEV
nsthorat pushed a commit that referenced this issue Mar 18, 2019
Don't publish _test.ts files on NPM. (#1401)
d40f181 
There is no need to publish the src/**/*_test.ts files.

It causes the tests to execute in dependent packages when those tests are run. This also decreases the NPM package size.

See #1380

DEV
nsthorat pushed a commit to tensorflow/tfjs-node that referenced this issue Mar 19, 2019
Don't publish _test.ts files on NPM. (#230)
d49e28e 
There is no need to publish the src/**/*_test.ts files.

It causes the tests to execute in dependent packages when those tests are run. This also decreases the NPM package size.

See tensorflow/tfjs#1380

DEV
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nsthorat nsthorat

Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nsthorat @caisq