Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't publish _test.ts files on NPM. #1401

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Don't publish _test.ts files on NPM. #1401

merged 1 commit into from
Mar 18, 2019

Conversation

nsthorat
Copy link
Contributor

@nsthorat nsthorat commented Mar 18, 2019

There is no need to publish the src/**/*_test.ts files.

It causes the tests to execute in dependent packages when those tests are run. This also decreases the NPM package size.

See #1380


This change is Reviewable

@nsthorat nsthorat requested review from dsmilkov, caisq and nkreeger March 18, 2019 17:52
@nsthorat nsthorat merged commit d40f181 into master Mar 18, 2019
@nsthorat nsthorat deleted the npmtest branch March 18, 2019 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants