Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Add BigInt to the list of primitive values #1769

Merged
merged 1 commit into from
Nov 8, 2019
Merged

Editorial: Add BigInt to the list of primitive values #1769

merged 1 commit into from
Nov 8, 2019

Conversation

chicoxyzzy
Copy link
Member

@chicoxyzzy chicoxyzzy commented Nov 2, 2019 •
edited
Loading

BigInt is missing in the list of primitive values

syg
syg reviewed Nov 2, 2019
View reviewed changes
Copy link
Contributor

@syg syg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. It'd be nice to update the "A primitive value is..." sentence in 4.2, as well as add "BigInt type" and "BigInt object" to the list of definitions in 4.3

syg
syg approved these changes Nov 2, 2019
View reviewed changes
Copy link
Contributor

@syg syg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@ljharb ljharb requested review from a team, michaelficarra and bakkot November 2, 2019 04:13
ljharb
ljharb approved these changes Nov 2, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch!

@ljharb ljharb self-assigned this Nov 2, 2019
bakkot
bakkot reviewed Nov 4, 2019
View reviewed changes
bakkot
bakkot reviewed Nov 4, 2019
View reviewed changes
@ljharb ljharb requested a review from bakkot November 5, 2019 16:10
@ljharb ljharb force-pushed the bigint_as_primitive_value branch from d36231c to d1b6707 Compare November 8, 2019 23:21
@ljharb ljharb merged commit d1b6707 into tc39:master Nov 8, 2019
@chicoxyzzy chicoxyzzy deleted the bigint_as_primitive_value branch November 9, 2019 09:53
@bathos bathos mentioned this pull request Nov 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@syg syg syg approved these changes

@michaelficarra michaelficarra michaelficarra approved these changes

@bakkot bakkot bakkot approved these changes

Assignees

@ljharb ljharb

Labels
editorial change spec bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chicoxyzzy @ljharb @syg @michaelficarra @bakkot