Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Add BigInt to the list of reference base value types and the language types intro text #1773

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

bathos
Copy link
Contributor

@bathos bathos commented Nov 11, 2019

Similar to #1769 — BigInt was absent from the list of types that the base value component of a Reference could be.

Note that it is already included and handled as a possible base value in the HasPrimitiveBase abstract op.

I was unsure if there was any particular logic to the ordering of types, so I just slotted it in the ‘most alphabetic’ seeming part of the list. Alternatively, the sentence could be reworded to avoid listing them all if it’s felt that this is becoming an update hazard, e.g.

The base value component is either an Environment Record or a language type other than Null.

Or, if it’s desired to draw additional attention to undefined’s distinct significance here:

The base value component is either an Environment Record or a language type other than Null (but including undefined).

(ref #1515)

@claudepache
Copy link
Contributor

claudepache commented Nov 11, 2019

Alternatively, this could be reworded to avoid listing them all, e.g.

The base value component is either an Environment Record or a language type other than Null.

undefined plays a special role which could have better been modelled as empty. IMO, a better rewording would be:

The base value component is either undefined, or an ECMAScript language type other than Undefined and Null, or an Environment Record.

EDIT: I meant, of course:

The base value component is either undefined, or an ECMAScript language value other than undefined and null, or an Environment Record.

@claudepache
Copy link
Contributor

claudepache commented Nov 11, 2019

BTW, another place where BigInt is still missing, is in the list of types found in the introductory paragraph of Section 6.1 ECMAScript language type.

@bathos
Copy link
Contributor Author

bathos commented Nov 11, 2019

Thanks @claudepache, I’ve added the missing one you mentioned. For now I’ve left the full enumeration in the base value list to err on the side of minimal change, but will update it if it turns out there’s general agreement that a briefer version would be better.

@bathos bathos changed the title Editorial: Add BigInt to the list of possible reference base value types Editorial: Add BigInt to the lists of reference base value types and the language types intro text Nov 11, 2019
@bathos bathos changed the title Editorial: Add BigInt to the lists of reference base value types and the language types intro text Editorial: Add BigInt to the list of reference base value types and the language types intro text Nov 11, 2019
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this fix focused, and leave larger refactors to a followup PR.

@ljharb ljharb self-assigned this Nov 12, 2019
@bakkot
Copy link
Contributor

bakkot commented Nov 12, 2019

It is also missing from the first step of CreateListFromArrayLike. I've checked the rest of the spec and found no other omissions.

@caiolima
Copy link
Contributor

Thank you very much for this PR!

@ljharb ljharb force-pushed the bigint-reference-base branch from 935ab9c to 788736c Compare November 19, 2019 06:39
@ljharb ljharb merged commit 788736c into tc39:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants