-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: Add BigInt to the list of reference base value types and the language types intro text #1773
Conversation
EDIT: I meant, of course:
|
BTW, another place where BigInt is still missing, is in the list of types found in the introductory paragraph of Section 6.1 ECMAScript language type. |
Thanks @claudepache, I’ve added the missing one you mentioned. For now I’ve left the full enumeration in the base value list to err on the side of minimal change, but will update it if it turns out there’s general agreement that a briefer version would be better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep this fix focused, and leave larger refactors to a followup PR.
It is also missing from the first step of CreateListFromArrayLike. I've checked the rest of the spec and found no other omissions. |
Thank you very much for this PR! |
935ab9c
to
788736c
Compare
Similar to #1769 — BigInt was absent from the list of types that the base value component of a Reference could be.
Note that it is already included and handled as a possible base value in the HasPrimitiveBase abstract op.
I was unsure if there was any particular logic to the ordering of types, so I just slotted it in the ‘most alphabetic’ seeming part of the list. Alternatively, the sentence could be reworded to avoid listing them all if it’s felt that this is becoming an update hazard, e.g.
Or, if it’s desired to draw additional attention to undefined’s distinct significance here:
(ref #1515)