Support distributing royalty token on registration #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mintAndRegisterIpAndAttachPilTermsAndDistributeRoyaltyTokens methods
…kens and mintAndRegisterIpAndAttachPilTermsAndDistributeRoyaltyTokens methods
bonnie57
requested review from
LeoHChen,
DonFungible,
edisonz0718,
jacob-tucker and
AndyBoWu
as code owners
bonnie57
had a problem deploying
to
beta-sepolia
GitHub Actions
Failure
bonnie57
had a problem deploying
to
beta-sepolia
GitHub Actions
Failure
allenchuang
pushed a commit
that referenced
this pull request
Dec 3, 2024
* Update smart contract methods * Fix multicall request types * Update registerPilTermsAndAttach to accept array of terms * Update mintAndRegisterIpAndAttachPILTerms to accept array of terms * Update signature method * Update smart contract methods in config * Add registerIPAndAttachLicenseTermsAndDistributeRoyaltyTokens method * Fix issue about how to get license terms id * Add registerDerivativeAndAttachLicenseTermsAndDistributeRoyaltyTokens method * Add mintAndRegisterIpAndMakeDerivativeAndDistributeRoyaltyTokens and mintAndRegisterIpAndAttachPilTermsAndDistributeRoyaltyTokens methods * Add unit for mintAndRegisterIpAndMakeDerivativeAndDistributeRoyaltyTokens and mintAndRegisterIpAndAttachPilTermsAndDistributeRoyaltyTokens methods * Fix unit tests * Refactor code * Bump up version to 1.2.0-rc.3 * Remove integration tests in test command * Update package.json
DonFungible
pushed a commit
that referenced
this pull request
Dec 3, 2024
* Update smart contract methods * Fix multicall request types * Update registerPilTermsAndAttach to accept array of terms * Update mintAndRegisterIpAndAttachPILTerms to accept array of terms * Update signature method * Update smart contract methods in config * Add registerIPAndAttachLicenseTermsAndDistributeRoyaltyTokens method * Fix issue about how to get license terms id * Add registerDerivativeAndAttachLicenseTermsAndDistributeRoyaltyTokens method * Add mintAndRegisterIpAndMakeDerivativeAndDistributeRoyaltyTokens and mintAndRegisterIpAndAttachPilTermsAndDistributeRoyaltyTokens methods * Add unit for mintAndRegisterIpAndMakeDerivativeAndDistributeRoyaltyTokens and mintAndRegisterIpAndAttachPilTermsAndDistributeRoyaltyTokens methods * Fix unit tests * Refactor code * Bump up version to 1.2.0-rc.3 * Remove integration tests in test command * Update package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Features
Tests