Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support distributing royalty token on registration #328

Merged
merged 16 commits into from
Dec 3, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix multicall request types
  • Loading branch information
bonnie57 committed Nov 25, 2024
commit 4dc74067e647576f5f17f3b2c113c4cff50e675c
2 changes: 1 addition & 1 deletion packages/core-sdk/src/resources/ipAsset.ts
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ export class IPAssetClient {
* @param request.args.ipMetadata.ipMetadataHash [Optional] The hash of the metadata for the IP.
* @param request.args.ipMetadata.nftMetadataURI [Optional] The URI of the metadata for the NFT.
* @param request.args.ipMetadata.nftMetadataHash [Optional] The hash of the metadata for the IP NFT.
* @param request.txOptions [Optional] This extends `WaitForTransactionReceiptParameters` from the Viem library, excluding the `hash` property.
* @param request.txOptions [Optional] This extends `WaitForTransactionReceiptParameters` from the Viem library, excluding the `hash` property, without encodedTxDataOnly option.
* @returns A Promise that resolves to a transaction hash, if waitForTransaction is true, includes IP ID, Token ID.
* @emits IPRegistered (ipId, chainId, tokenContract, tokenId, resolverAddr, metadataProviderAddress, metadata)
*/
Expand Down
4 changes: 2 additions & 2 deletions packages/core-sdk/src/types/resources/ipAsset.ts
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ export type BatchMintAndRegisterIpAssetWithPilTermsResponse = {
export type BatchRegisterDerivativeRequest = {
args: RegisterDerivativeRequest[];
deadline?: string | number | bigint;
txOptions?: TxOptions;
txOptions?: Omit<TxOptions, "encodedTxDataOnly">;
};

export type BatchRegisterDerivativeResponse = {
Expand All @@ -257,7 +257,7 @@ export type BatchMintAndRegisterIpAndMakeDerivativeResponse = {

export type BatchRegisterRequest = {
args: Omit<RegisterRequest, "txOptions">[];
txOptions?: TxOptions;
txOptions?: Omit<TxOptions, "encodedTxDataOnly">;
};

export type BatchRegisterResponse = {
Expand Down