Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove jquery-form (#8232)" #8237

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

dmaicher
Copy link
Contributor

@dmaicher dmaicher commented Feb 3, 2025

This reverts commit ccd3492.

See #8232 (comment)

Subject

Changelog

### Added
- Add back previously removed jquery-form plugin

@dmaicher
Copy link
Contributor Author

dmaicher commented Feb 3, 2025

npx encore production does not produce any diff for app.js. So reverting the commit should be fine?

there is a CI check for it anyway I saw

@dmaicher
Copy link
Contributor Author

dmaicher commented Feb 3, 2025

Checking the build fail 😕

Seems Symfony is not fully compatible with doctrine/persistence 4 yet

.........PHP Fatal error:  Declaration of Symfony\Component\Security\Acl\Domain\Acl::addPropertyChangedListener(Doctrine\Persistence\PropertyChangedListener $listener) must be compatible with Doctrine\Persistence\NotifyPropertyChanged::addPropertyChangedListener(Doctrine\Persistence\PropertyChangedListener $listener): void in /var/www/SonataAdminBundle/vendor/symfony/security-acl/Domain/Acl.php on line 70

@@ -68,6 +68,7 @@
"twig/twig": "^3.0"
},
"require-dev": {
"doctrine/persistence": "^3.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

until /~https://github.com/symfony/security-acl is compatible. Will look into it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VincentLanglet VincentLanglet merged commit edb5824 into sonata-project:4.x Feb 4, 2025
23 checks passed
@VincentLanglet
Copy link
Member

Thanks !

@dmaicher dmaicher deleted the revert_jquery_form branch February 4, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants