Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jquery-form #8232

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

onEXHovia
Copy link
Contributor

@onEXHovia onEXHovia commented Dec 11, 2024

Subject

Sonata not used this plugin, im not found ajaxForm calls.
Projects that use this plugin should add it to root package.json.

Changelog

### Removed
- Remove jquery-form plugin

@onEXHovia
Copy link
Contributor Author

(rebased)

@VincentLanglet VincentLanglet merged commit ccd3492 into sonata-project:4.x Dec 19, 2024
23 checks passed
@onEXHovia onEXHovia deleted the remove-jquery-form branch December 19, 2024 09:39
@dmaicher
Copy link
Contributor

dmaicher commented Feb 3, 2025

@onEXHovia this unfortunately broke some things for me. ajaxSubmit is still being used: /~https://github.com/search?q=repo%3Asonata-project%2FSonataAdminBundle%20ajaxSubmit&type=code

@VincentLanglet
Copy link
Member

Can someone open a revert/fix ?

dmaicher added a commit to dmaicher/SonataAdminBundle that referenced this pull request Feb 3, 2025
@onEXHovia
Copy link
Contributor Author

@onEXHovia this unfortunately broke some things for me. ajaxSubmit is still being used: /~https://github.com/search?q=repo%3Asonata-project%2FSonataAdminBundle%20ajaxSubmit&type=code

You are right, jquery-form plugin provide ajaxForm and ajaxSubmit methods, im was search only ajaxForm method.

VincentLanglet pushed a commit that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants