rustdoc: Improve playground run buttons #37098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| "" | ||
| }; | ||
| // These characters don't need to be escaped in a URI. | ||
| // FIXME: use a library function for percent encoding. |
|
Neat! I think this is a noble goal overall. @alexcrichton @GuillaumeGomez what do you think? /cc @rust-lang/tools as well. |
|
👍 |
|
I have shared feelings: on one side, it removes javascript and watchers, which is super nice. On the other side, we add more data into our docs. So I'm mostly in favor for this change. |
|
After consensus, let's merge it! Thanks a lot for this! @bors: r+ |
|
📌 Commit 6bc0ca6 has been approved by |
|
🔒 Merge conflict |
|
☔ The latest upstream changes (presumably #37118) made this pull request unmergeable. Please resolve the merge conflicts. |
The main change is to stop using javascript to generate the URLs and use rustdoc instead. This also adds run buttons to the error index examples.
ollie27
force-pushed
the
rustdoc_playground
branch
from
6bc0ca6 to
0b2746c
Compare
|
Rebased. |
|
@bors: r+ |
|
📌 Commit 0b2746c has been approved by |
bors
added a commit
that referenced
this pull request
Oct 16, 2016
rustdoc: Improve playground run buttons The main change is to stop using javascript to generate the URLs and use rustdoc instead. This also adds run buttons to the error index examples. You can test the changes at https://ollie27.github.io/rust_doc_test/. Fixes #36621 Fixes #36910
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is to stop using javascript to generate the URLs and use
rustdoc instead.
This also adds run buttons to the error index examples.
You can test the changes at https://ollie27.github.io/rust_doc_test/.
Fixes #36621
Fixes #36910