Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Renders Run button even if playpen is not enabled #36621

Closed
bluss opened this issue Sep 21, 2016 · 5 comments
Closed

rustdoc: Renders Run button even if playpen is not enabled #36621

bluss opened this issue Sep 21, 2016 · 5 comments
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@bluss
Copy link
Member

bluss commented Sep 21, 2016

rustdoc renders the Run button even if playpen is not enabled now. Clicking the button has no useful effect.

Was this caused by #36334 ?
@bluss bluss added A-docs T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. and removed A-docs labels Sep 21, 2016
@GuillaumeGomez
Copy link
Member

Do you have a page/code example please?

@bluss
Copy link
Member Author

bluss commented Sep 21, 2016 •
edited
Loading

Sure, http://bluss.github.io/arrayvec/doc/arrayvec/struct.ArrayVec.html as of today. Generated with rustc 1.13.0-nightly (32571c05c 2016-09-17)

Edit: That link is no longer current, but you can see in other places, like this doc page which was generated with the bug: https://docs.rs/itertools/0.5.0/itertools/

@GuillaumeGomez
Copy link
Member

I don't see any run button on the url you gave me. :-/

@bluss
Copy link
Member Author

bluss commented Sep 21, 2016 •
edited
Loading

Oh oops, I pushed an update so that it redirects to docs.rs. My bad.

@GuillaumeGomez
Copy link
Member

Ok, I understand what's wrong. I'll fix it as soon as I can.

@GuillaumeGomez GuillaumeGomez mentioned this issue Sep 21, 2016
Merged
@bluss bluss mentioned this issue Oct 2, 2016
Closed
bors added a commit that referenced this issue Oct 8, 2016
@bors
Auto merge of #36637 - GuillaumeGomez:fix_run_button, r=bluss
fcc354f 
Fixes run button appearing when it shouldn't

Fixes #36621.

r? @steveklabnik
bors added a commit that referenced this issue Oct 9, 2016
@bors
Auto merge of #36637 - GuillaumeGomez:fix_run_button, r=bluss
b98cc35 
Fixes run button appearing when it shouldn't

Fixes #36621.

r? @steveklabnik
@ollie27 ollie27 mentioned this issue Oct 11, 2016
Merged
bors added a commit that referenced this issue Oct 16, 2016
@bors
Auto merge of #37098 - ollie27:rustdoc_playground, r=GuillaumeGomez
6dc035e 
rustdoc: Improve playground run buttons

The main change is to stop using javascript to generate the URLs and use
rustdoc instead.

This also adds run buttons to the error index examples.

You can test the changes at https://ollie27.github.io/rust_doc_test/.

Fixes #36621
Fixes #36910
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GuillaumeGomez @bluss