Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in TxCtxt::crate_disambiguator() and add test case. #32579

Merged
merged 2 commits into from
Apr 3, 2016

Conversation

michaelwoerister
Copy link
Member

@eddyb
Copy link
Member

eddyb commented Mar 31, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Mar 31, 2016

📌 Commit a7d1ccc has been approved by eddyb

@bors
Copy link
Contributor

bors commented Apr 1, 2016

⌛ Testing commit a7d1ccc with merge 3959c95...

@bors
Copy link
Contributor

bors commented Apr 1, 2016

💔 Test failed - auto-win-gnu-32-nopt-t

@michaelwoerister michaelwoerister force-pushed the stable-symbol-name-fix branch from a7d1ccc to e55cef7 Compare April 1, 2016 17:59
@michaelwoerister
Copy link
Member Author

Rebased and made the test sort the nm output before comparing.

@michaelwoerister
Copy link
Member Author

@bors r=eddyb

@bors
Copy link
Contributor

bors commented Apr 1, 2016

📌 Commit e55cef7 has been approved by eddyb

@nikomatsakis
Copy link
Contributor

@bors p=1

@bors
Copy link
Contributor

bors commented Apr 2, 2016

⌛ Testing commit e55cef7 with merge b8f249c...

bors added a commit that referenced this pull request Apr 2, 2016
Fix typo in TxCtxt::crate_disambiguator() and add test case.

r? @nikomatsakis

Fixes #32554
@bors
Copy link
Contributor

bors commented Apr 2, 2016

💔 Test failed - auto-mac-32-opt

@michaelwoerister
Copy link
Member Author

It seems that there's actually something wrong on non-Linux systems. I'll try to reproduce locally.

@michaelwoerister michaelwoerister force-pushed the stable-symbol-name-fix branch from e55cef7 to c2ede7e Compare April 3, 2016 04:44
@michaelwoerister
Copy link
Member Author

For 32bit builds symbol address were not always the same. This is taken into account by the test now.

@michaelwoerister
Copy link
Member Author

@bors r=eddyb

@bors
Copy link
Contributor

bors commented Apr 3, 2016

📌 Commit c2ede7e has been approved by eddyb

@bors
Copy link
Contributor

bors commented Apr 3, 2016

⌛ Testing commit c2ede7e with merge a09f386...

bors added a commit that referenced this pull request Apr 3, 2016
Fix typo in TxCtxt::crate_disambiguator() and add test case.

r? @nikomatsakis

Fixes #32554
@bors bors merged commit c2ede7e into rust-lang:master Apr 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants