Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in TxCtxt::crate_disambiguator() and add test case. #32579

Merged
merged 2 commits into from
Apr 3, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/librustc/ty/context.rs
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ impl<'tcx> TyCtxt<'tcx> {
if cnum == LOCAL_CRATE {
self.sess.crate_disambiguator.get().as_str()
} else {
self.sess.cstore.crate_name(cnum)
self.sess.cstore.crate_disambiguator(cnum)
}
}

Expand Down
18 changes: 18 additions & 0 deletions src/test/run-make/stable-symbol-names/Makefile
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
-include ../tools.mk

# This test case makes sure that monomorphizations of the same function with the
# same set of generic arguments will have the same symbol names when
# instantiated in different crates.

dump-symbols = nm "$(TMPDIR)/lib$(1).rlib" \
| grep "some_test_function" \
| sed "s/^[0-9a-f]\{8,16\}/00000000/" \
| sort \
> "$(TMPDIR)/$(1).nm"

all:
$(RUSTC) stable-symbol-names1.rs
$(RUSTC) stable-symbol-names2.rs
$(call dump-symbols,stable_symbol_names1)
$(call dump-symbols,stable_symbol_names2)
cmp "$(TMPDIR)/stable_symbol_names1.nm" "$(TMPDIR)/stable_symbol_names2.nm"
22 changes: 22 additions & 0 deletions src/test/run-make/stable-symbol-names/stable-symbol-names1.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
// Copyright 2016 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#![crate_type="rlib"]

pub fn some_test_function<T>(t: T) -> T {
t
}

pub fn user() {
some_test_function(0u32);
some_test_function("abc");
let x = 2u64;
some_test_function(&x);
}
20 changes: 20 additions & 0 deletions src/test/run-make/stable-symbol-names/stable-symbol-names2.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// Copyright 2016 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#![crate_type="rlib"]

extern crate stable_symbol_names1;

pub fn user() {
stable_symbol_names1::some_test_function(1u32);
stable_symbol_names1::some_test_function("def");
let x = 2u64;
stable_symbol_names1::some_test_function(&x);
}