Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIRI: Tried to cache DefId(_), but was already existing as AllocId(_) #49081

Closed
michaelwoerister opened this issue Mar 16, 2018 · 3 comments · Fixed by #49079 or #49424
Closed

MIRI: Tried to cache DefId(_), but was already existing as AllocId(_) #49081

michaelwoerister opened this issue Mar 16, 2018 · 3 comments · Fixed by #49079 or #49424
Assignees
@oli-obk
Labels
A-const-eval Area: Constant evaluation, covers all const contexts (static, const fn, ...) I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ P-high High priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@michaelwoerister
Copy link
Member

The following crash occurs during incremental compilation of the rust-url crate:
https://travis-ci.org/rust-icci/rust-url/jobs/354013054#L1157-L1159

cc @oli-obk @eddyb
@michaelwoerister michaelwoerister added I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 16, 2018
@oli-obk oli-obk self-assigned this Mar 16, 2018
@oli-obk
Copy link
Contributor

oli-obk commented Mar 16, 2018

minimal repro:

pub static A: i32 = 42;
pub static B: &i32 = &A;

@michaelwoerister
Copy link
Member Author

@oli-obk remarked on IRC that this might be temporarily worked around by not caching upstream constants.

This was referenced Mar 16, 2018
Closed
Merged
@nikomatsakis
Copy link
Contributor

triage: P-high

Regression.

@rust-highfive rust-highfive added P-high High priority and removed I-nominated labels Mar 16, 2018
@nikomatsakis nikomatsakis mentioned this issue Mar 16, 2018
Closed
bors added a commit that referenced this issue Mar 19, 2018
@bors
Auto merge of #49079 - oli-obk:cross_miri, r=michaelwoerister
a04b88d 
Cleanup metadata and incremental cache processing of constants

fixes #49033
fixes #49081

we really need tests for this. do we have any cross compilation tests? I couldn't find any
@pietroalbini pietroalbini mentioned this issue Mar 20, 2018
Merged
@oli-obk oli-obk mentioned this issue Mar 27, 2018
Merged
bors added a commit that referenced this issue Mar 30, 2018
@bors
Auto merge of #49424 - oli-obk:stable_allocid_hash, r=michaelwoerister
051050d 
Fix stable hashing of AllocIds

r? @michaelwoerister

fixes #49081
@RalfJung RalfJung added the A-const-eval Area: Constant evaluation, covers all const contexts (static, const fn, ...) label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oli-obk oli-obk

Labels
A-const-eval Area: Constant evaluation, covers all const contexts (static, const fn, ...) I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ P-high High priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
5 participants
@nikomatsakis @RalfJung @oli-obk @michaelwoerister @rust-highfive