Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: all the Travis caches needs to be cleaned before merging this. The old stable cache is broken as far as I understand, and the migration to rustfmt-preview may cause problems to the lints job. Anyone with push access to this repo can do it on this page, with the "delete all repository caches" button.
Travis speed on this repository is pretty bad (not rustc-bad, but a simple commit takes more than 20 minutes to test), and with this PR I'm trying to solve that. There are a few problems at the moment:
build
/clippy
step is done withRUSTFLAGS=-Dwarnings
and thetest
one withoutThis PR addresses those problems:
RUSTFLAGS=-Dwarnings
, so it doesn't invalidate all the cached dependencies multiple times on each buildI have to say, the result of this is really good (we go from a 20+ minutes wait to about 3 minutes):