Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ruby 2.5 support, drop 2.2. #1813

Merged
merged 4 commits into from
Nov 3, 2018
Merged

Add ruby 2.5 support, drop 2.2. #1813

merged 4 commits into from
Nov 3, 2018

Conversation

darren987469
Copy link
Contributor

@darren987469 darren987469 commented Nov 2, 2018 •
edited
Loading

Summary

  • Update ruby, rails, rack version in travis.
  • Add ruby 2.5 support, drop 2.2.

The new version of ruby is released. Update travis settings.
Reference: https://www.ruby-lang.org/zh_tw/

@darren987469 darren987469 force-pushed the update_ruby_version_in_travis branch from c4a5c0c to 2b7b7eb Compare November 2, 2018 23:50
@darren987469 darren987469 force-pushed the update_ruby_version_in_travis branch from 2b7b7eb to 9c942f4 Compare November 3, 2018 00:22
@grape-bot
Copy link

1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Generated by 🚫 danger

@darren987469 darren987469 changed the title [WIP] Update ruby version in travis Add ruby 2.5 support, drop 2.2. Nov 3, 2018
@darren987469 darren987469 mentioned this pull request Nov 3, 2018
Merged
@dblock dblock merged commit 5736a8a into ruby-grape:master Nov 3, 2018
@dblock
Copy link
Member

dblock commented Nov 3, 2018

👍

@dm1try
Copy link
Member

dm1try commented Nov 3, 2018

should /~https://github.com/ruby-grape/grape/blob/master/Appraisals file being updated too?

dm1try
dm1try reviewed Nov 3, 2018
View reviewed changes
gemfiles/rack_1.5.5.gemfile
@@ -2,7 +2,7 @@

source 'https://rubygems.org'

gem 'rack', '1.5.2'
gem 'rack', '1.5.5'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to remove this "appraisal", as it was added specifically for fixing #1066(missing patch version in rack 1.5.2).
any objections?

moreover, now I think it does not worth it :)

dm1try
dm1try reviewed Nov 3, 2018
View reviewed changes
spec/grape/integration/rack_spec.rb
@@ -22,7 +22,7 @@
unless RUBY_PLATFORM == 'java'
major, minor, patch = Rack.release.split('.').map(&:to_i)
patch ||= 0 # rack <= 1.5.2 does not specify patch version
pending 'Rack 1.5.3 or 1.6.1 required' unless major >= 2 || (major >= 1 && ((minor == 5 && patch >= 3) || (minor >= 6)))
pending 'Rack 1.5.5 or 1.6.1 required' unless major >= 2 || (major >= 1 && ((minor == 5 && patch >= 5) || (minor >= 6)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be changed, see #1066

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dm1try You are right. Thanks for catching that.

Is it a proper way to remove conditional pending test and update the gem dependency?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darren987469 no worries, I addressed this in 87b6243

@dm1try
Copy link
Member

dm1try commented Nov 3, 2018

maybe it's a good time to drop rails 3.2 support and bump dependencies.

@darren987469 darren987469 deleted the update_ruby_version_in_travis branch November 4, 2018 04:21
dm1try added a commit that referenced this pull request Nov 4, 2018
@dm1try
update Appraisals according to the latest changes
d752a65 
ref #1813
dm1try added a commit that referenced this pull request Nov 4, 2018
@dm1try
Revert "Update rack from 1.5.2 to 1.5.5"
87b6243 
This reverts commit 022a642.

rm useless appraisal

ref #1813, #1066
artur-intech pushed a commit to internetee/registry that referenced this pull request Feb 28, 2019
Update grape gem
4bd0c0b 
1.2.0 support Ruby 2.5
ruby-grape/grape#1813

#846
@artur-intech artur-intech mentioned this pull request Feb 28, 2019
Merged
artur-intech pushed a commit to internetee/registry that referenced this pull request Feb 28, 2019
Update grape gem
a565c43 
1.2.0 supports Ruby 2.5
ruby-grape/grape#1813
basjanssen pushed a commit to basjanssen/grape that referenced this pull request Feb 28, 2020
@dm1try @basjanssen
update Appraisals according to the latest changes
cf02af4 
ref ruby-grape#1813
basjanssen pushed a commit to basjanssen/grape that referenced this pull request Feb 28, 2020
@dm1try @basjanssen
Revert "Update rack from 1.5.2 to 1.5.5"
e99e88b 
This reverts commit 022a642.

rm useless appraisal

ref ruby-grape#1813, ruby-grape#1066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dm1try dm1try dm1try left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@darren987469 @grape-bot @dblock @dm1try