Add spec for default value in given block #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's an example of a CHANGELOG.md entry: * [#1812](/~https://github.com/ruby-grape/grape/pull/1812): Add spec for default value in given block - [@darren987469](/~https://github.com/darren987469).Generated by 🚫 danger |
|
There's some dependency/ruby version changes that failed the build here. Appreciate if you could please try to fix that? Upgrading those rubies seems to be the right way to go. Thanks. |
|
I open another PR to add ruby 2.5 support and drop 2.2 support (#1813 ). After 1813 merged, I will rebase it and CI should pass. |
|
Merged it, thanks @darren987469 |
darren987469
force-pushed
the
add_spec_for_issue_1681
branch
from
bc6136c to
513f857
Compare
|
@dblock Rebased and CI passes! |
|
Merged, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add spec for #1681. The issue seems already fixed.