Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version to v2.23.0 #1672

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Bump version to v2.23.0 #1672

merged 1 commit into from
Jul 30, 2023

Conversation

bquorning
Copy link
Collaborator

It has been a couple of months. Are we ready for the next release? Are there some more pull requests we need to get merged first?

@bquorning bquorning requested review from pirj, Darhazer and ydah July 17, 2023 07:08
@ydah
Copy link
Member

ydah commented Jul 17, 2023 •
edited
Loading

We would like to include the next version.

These PRs are not urgent as they are an addition to the cop:

pirj
pirj approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@Darhazer
Copy link
Member

Let's release 👍

ydah
ydah approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@ydah ydah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bquorning
Copy link
Collaborator Author

Let’s get #1666 merged first, then rebase this PR. I am unable to do the actual release for the next week or so, but feel free to do it without me.

@bquorning
Copy link
Collaborator Author

bquorning commented Jul 30, 2023 •
edited
Loading

I have rebased this PR, and it’s now ready for review.

We’ll leave #1666 for the next release, I hope that’s ok with @ydah

ydah
ydah approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@ydah ydah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We leave #1666 until the next release👍
Let's proceed with the release 🚀

Darhazer
Darhazer approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@Darhazer Darhazer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bquorning bquorning merged commit d66612b into master Jul 30, 2023
@bquorning bquorning deleted the release branch July 30, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ydah ydah ydah approved these changes

@Darhazer Darhazer Darhazer approved these changes

@pirj pirj pirj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bquorning @ydah @Darhazer @pirj