Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to v2.23.0 #1672

Merged
merged 1 commit into from
Jul 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Master (Unreleased)

## 2.23.0 (2023-07-30)

- Add new `RSpec/Rails/NegationBeValid` cop. ([@ydah])
- Fix a false negative for `RSpec/ExcessiveDocstringSpacing` when finds description with em space. ([@ydah])
- Fix a false positive for `RSpec/EmptyExampleGroup` when example group with examples defined in `if` branch inside iterator. ([@ydah])
Expand Down
16 changes: 8 additions & 8 deletions config/default.yml
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ RSpec/BeforeAfterAll:
- "**/spec/rails_helper.rb"
- "**/spec/support/**/*.rb"
VersionAdded: '1.12'
VersionChanged: "<<next>>"
VersionChanged: '2.23'
StyleGuide: https://rspec.rubystyle.guide/#avoid-hooks-with-context-scope
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/BeforeAfterAll

Expand Down Expand Up @@ -407,7 +407,7 @@ RSpec/ExpectActual:
Exclude:
- "**/spec/routing/**/*"
VersionAdded: '1.7'
VersionChanged: "<<next>>"
VersionChanged: '2.23'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExpectActual

RSpec/ExpectChange:
Expand Down Expand Up @@ -515,7 +515,7 @@ RSpec/IndexedLet:
Description: Do not set up test data using indexes (e.g., `item_1`, `item_2`).
Enabled: pending
VersionAdded: '2.20'
VersionChanged: "<<next>>"
VersionChanged: '2.23'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/IndexedLet
Max: 1
AllowedIdentifiers: []
Expand Down Expand Up @@ -733,7 +733,7 @@ RSpec/ReceiveCounts:
RSpec/ReceiveMessages:
Description: Checks for multiple messages stubbed on the same object.
Enabled: pending
VersionAdded: "<<next>>"
VersionAdded: '2.23'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ReceiveMessages

RSpec/ReceiveNever:
Expand Down Expand Up @@ -989,7 +989,7 @@ RSpec/FactoryBot/AttributeDefinedStatically:
- "**/spec/factories/**/*.rb"
- "**/features/support/factories/**/*.rb"
VersionAdded: '1.28'
VersionChanged: "<<next>>"
VersionChanged: '2.23'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/AttributeDefinedStatically

RSpec/FactoryBot/ConsistentParenthesesStyle:
Expand All @@ -1016,7 +1016,7 @@ RSpec/FactoryBot/CreateList:
- create_list
- n_times
VersionAdded: '1.25'
VersionChanged: "<<next>>"
VersionChanged: '2.23'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/CreateList

RSpec/FactoryBot/FactoryClassName:
Expand All @@ -1027,7 +1027,7 @@ RSpec/FactoryBot/FactoryClassName:
- "**/spec/factories/**/*.rb"
- "**/features/support/factories/**/*.rb"
VersionAdded: '1.37'
VersionChanged: "<<next>>"
VersionChanged: '2.23'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/FactoryClassName

RSpec/FactoryBot/FactoryNameStyle:
Expand Down Expand Up @@ -1113,7 +1113,7 @@ RSpec/Rails/NegationBeValid:
- not_to
- be_invalid
Enabled: pending
VersionAdded: "<<next>>"
VersionAdded: '2.23'
Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Rails/NegationBeValid

RSpec/Rails/TravelAround:
Expand Down
2 changes: 1 addition & 1 deletion docs/antora.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: rubocop-rspec
title: RuboCop RSpec
version: ~
version: '2.23'
nav:
- modules/ROOT/nav.adoc
8 changes: 4 additions & 4 deletions docs/modules/ROOT/pages/cops_rspec.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ expect(foo).to be(nil)
| Yes
| No
| 1.12
| <<next>>
| 2.23
|===

Check that before/after(:all) isn't being used.
Expand Down Expand Up @@ -1767,7 +1767,7 @@ end
| Yes
| Yes
| 1.7
| <<next>>
| 2.23
|===

Checks for `expect(...)` calls containing literal values.
Expand Down Expand Up @@ -2476,7 +2476,7 @@ it { expect(named_subject).to be_truthy }
| Yes
| No
| 2.20
| <<next>>
| 2.23
|===

Do not set up test data using indexes (e.g., `item_1`, `item_2`).
Expand Down Expand Up @@ -4272,7 +4272,7 @@ expect(foo).to receive(:bar).at_most(:twice).times
| Pending
| Yes
| Yes
| <<next>>
| 2.23
| -
|===

Expand Down
6 changes: 3 additions & 3 deletions docs/modules/ROOT/pages/cops_rspec_factorybot.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
| Yes
| Yes
| 1.28
| <<next>>
| 2.23
|===

Always declare attribute values as blocks.
Expand Down Expand Up @@ -131,7 +131,7 @@ build(
| Yes
| Yes
| 1.25
| <<next>>
| 2.23
|===

Checks for create_list usage.
Expand Down Expand Up @@ -198,7 +198,7 @@ create_list :user, 3
| Yes
| Yes
| 1.37
| <<next>>
| 2.23
|===

Use string value when setting the class attribute explicitly.
Expand Down
2 changes: 1 addition & 1 deletion docs/modules/ROOT/pages/cops_rspec_rails.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ expect(b).not_to eq(a)
| Pending
| Yes
| Yes
| <<next>>
| 2.23
| -
|===

Expand Down
2 changes: 1 addition & 1 deletion lib/rubocop/rspec/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module RuboCop
module RSpec
# Version information for the RSpec RuboCop plugin.
module Version
STRING = '2.22.0'
STRING = '2.23.0'
end
end
end