Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OTEL panic on nil map access #68

Merged
merged 1 commit into from
May 8, 2023
Merged

Conversation

rustatian
Copy link
Member

Reason for This PR

closes: roadrunner-server/roadrunner#1553

Description of Changes

  1. If there are no headers in the AMQP table, make an empty map to pass to the OTEL propogator.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added the enhancement New feature or request label May 8, 2023
@rustatian rustatian requested a review from wolfy-j May 8, 2023 15:52
@rustatian rustatian self-assigned this May 8, 2023
@rustatian rustatian marked this pull request as ready for review May 8, 2023 15:52
@rustatian rustatian merged commit f44bf72 into master May 8, 2023
@rustatian rustatian deleted the fix/nil_otel_headers_panic branch May 8, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[🐛 BUG]: AMQP driver crashes after failing to propagate OTEL headers
1 participant