Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 BUG]: AMQP driver crashes after failing to propagate OTEL headers #1553

Closed
1 task done
rauanmayemir opened this issue May 8, 2023 · 0 comments · Fixed by roadrunner-server/amqp#68
Closed
1 task done
Assignees
Labels
B-bug Bug: bug, exception F-need-verification
Milestone

Comments

@rauanmayemir
Copy link

No duplicates 🥲.

  • I have searched for a similar issue in our bug tracker and didn't find any solutions.

What happened?

After upgrading the RR from 2.13.2 to 2023.1.2 my pods started crashing with the following trace:

 net/http/header.go:40
go.opentelemetry.io/otel/propagation.HeaderCarrier.Set(0x1e15faf?, {0x1e14129?, 0xc00058f700?}, {0xc000518180, 0x37})
 go.opentelemetry.io/otel@v1.14.0/propagation/propagation.go:79 +0x97
go.opentelemetry.io/otel/propagation.TraceContext.Inject({}, {0x22a1b88?, 0xc0005968d0?}, {0x22a0ed0, 0x0})
 go.opentelemetry.io/otel@v1.14.0/propagation/trace_context.go:65 +0x41c
go.opentelemetry.io/otel/propagation.compositeTextMapPropagator.Inject(...)
 go.opentelemetry.io/otel@v1.14.0/propagation/propagation.go:117
github.com/roadrunner-server/amqp/v4/amqpjobs.(*Driver).listener.func1()
 github.com/roadrunner-server/amqp/v4@v4.4.7/amqpjobs/listener.go:49 +0x35e
created by github.com/roadrunner-server/amqp/v4/amqpjobs.(*Driver).listener
 github.com/roadrunner-server/amqp/v4@v4.4.7/amqpjobs/listener.go:15 +0x72
panic: assignment to entry in nil map

Version (rr --version)

2023.1.2

How to reproduce the issue?

No way to reproduce as it's only been discovered on high-traffic workloads. It's been working perfectly fine in my test env.

Relevant log output

No response

@rauanmayemir rauanmayemir added B-bug Bug: bug, exception F-need-verification labels May 8, 2023
@rustatian rustatian added this to General May 8, 2023
@github-project-automation github-project-automation bot moved this to Backlog in General May 8, 2023
@rustatian rustatian moved this from Backlog to Todo in General May 8, 2023
@rustatian rustatian added this to the 2023.1.3 milestone May 8, 2023
@github-project-automation github-project-automation bot moved this from Todo to Unreleased in General May 8, 2023
@rustatian rustatian mentioned this issue May 11, 2023
6 tasks
@rustatian rustatian moved this from Unreleased to Done in General May 25, 2023
@rustatian rustatian mentioned this issue May 25, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-bug Bug: bug, exception F-need-verification
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants