[REF-2956]Fail When Backend port or frontend port is explicitly provided and the port is in use #3432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElijahAhianyo
changed the title
ElijahAhianyo
changed the title
ElijahAhianyo
changed the title
picklelo
approved these changes
Jun 5, 2024
| Exit:when the port is in use. | ||
| """ | ||
| if is_process_on_port(port): | ||
| if int(port) == int(default_port): |
There was a problem hiding this comment.
I think we need to handle the case where they specifically, but it seems hard to do with how we're handling the default values now. We can come back to this if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the backend port or frontend port is provided (in the config or as a CLI argument), we should avoid auto-selecting the next available port. Instead, we should throw an error and exit the application completely.
fixes #3385