Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF-2956] New Auto Port Select Feature is Overriding Config #3385

Closed
deanchanter opened this issue May 26, 2024 · 5 comments · Fixed by #3432
Closed

[REF-2956] New Auto Port Select Feature is Overriding Config #3385

deanchanter opened this issue May 26, 2024 · 5 comments · Fixed by #3432
Labels
linear Created by Linear-GitHub Sync Reflex > Open source core OSS Created by Linear-GitHub Sync
Milestone

Comments

@deanchanter
Copy link

deanchanter commented May 26, 2024

Describe the bug
The new auto port select feature is overriding the config. When a backend port is in config the app gets confused and loses connectivity.

To Reproduce
Steps to reproduce the behavior:
`config = ReflexappConfig(
frontend_port=3001,
backend_port=2000,
app_name="app",
api_url="http://localhost:2000",

)`

Expected behavior
If ports are in the config fall back to old method of asking the user what to do

Screenshots
If applicable, add screenshots to help explain your problem.

Specifics (please complete the following information):

  • Python Version:3.11
  • Reflex Version:5.1
  • OS: MacOS
  • Browser (Optional):FireFox

Additional context
Add any other context about the problem here.

REF-2956

@deanchanter deanchanter added the bug Something isn't working label May 26, 2024
@deanchanter
Copy link
Author

It fails most often after a hot reload.

@masenf masenf added the linear Created by Linear-GitHub Sync label May 26, 2024
@masenf masenf changed the title New Auto Port Select Feature is Overriding Config [REF-2956] New Auto Port Select Feature is Overriding Config May 26, 2024
@masenf
Copy link
Collaborator

masenf commented May 26, 2024

Thanks for reporting, we'll look into it.

Is your ideal behavior prompting the user whether to kill or change port? Or if the backend_port is provided in the config and not available, should reflex fail to start?

@deanchanter
Copy link
Author

deanchanter commented May 26, 2024 via email

@masenf
Copy link
Collaborator

masenf commented May 26, 2024

I guess that was kind of an xor question... if the port is defined, is your preference that reflex a) prompts xor b) fails?

@deanchanter
Copy link
Author

deanchanter commented May 26, 2024 via email

@masenf masenf modified the milestones: Open Source Bugs, v.37 Jun 3, 2024
@masenf masenf added Reflex > Open source core OSS Created by Linear-GitHub Sync bug Something isn't working and removed bug Something isn't working labels Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear Created by Linear-GitHub Sync Reflex > Open source core OSS Created by Linear-GitHub Sync
Projects
None yet
2 participants