Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v24.2.x] Do not download the partition manifest when creating learner #24680

Merged
merged 2 commits into from
Jan 3, 2025
Merged

[v24.2.x] Do not download the partition manifest when creating learner #24680

merged 2 commits into from
Jan 3, 2025

Conversation

mmaslankaprv
Copy link
Member

Backport of PR #24664

@mmaslankaprv mmaslankaprv added this to the v24.2.x-next milestone Jan 3, 2025
@mmaslankaprv mmaslankaprv added the kind/backport PRs targeting a stable branch label Jan 3, 2025
@mmaslankaprv mmaslankaprv marked this pull request as ready for review January 3, 2025 07:19
@mmaslankaprv mmaslankaprv requested review from bharathv and ztlpn January 3, 2025 07:19
@piyushredpanda piyushredpanda modified the milestones: v24.2.x-next, v24.2.15 Jan 3, 2025
@mmaslankaprv mmaslankaprv force-pushed the manual-backport-24664-v24.2.x-960 branch from 8f5c5ca to 299f48c Compare January 3, 2025 08:07
@mmaslankaprv
c/backend: do not download the partition manifest when creating learner
bd8a621 
When learner replica is created its state should not be seeded by the
recovery machinery but rather than that it must be recovered by Raft.
Using remote recovery when creating the learner replicas may lead to
archival_stm issues as some commands are applied more than once.

Signed-off-by: Michał Maślanka <michal@redpanda.com>
(cherry picked from commit 481b47b)
@mmaslankaprv
tests: added scaling up test with recovered topic
5af7871 
Added tests triggering partition replica set reconfiguration with
topics which are recovered.

Signed-off-by: Michał Maślanka <michal@redpanda.com>
(cherry picked from commit fff2b72)
@mmaslankaprv mmaslankaprv force-pushed the manual-backport-24664-v24.2.x-960 branch from 299f48c to 5af7871 Compare January 3, 2025 08:46
@vbotbuildovich
Copy link
Collaborator

Retry command for Build#60259

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/archive_retention_test.py::CloudArchiveRetentionTest.test_delete@{"cloud_storage_type":2,"retention_type":"retention.bytes"}

@vbotbuildovich
Copy link
Collaborator

CI test results

test results on build#60259
test_id test_kind job_url test_status passed
rptest.tests.archive_retention_test.CloudArchiveRetentionTest.test_delete.cloud_storage_type=CloudStorageType.ABS.retention_type=retention.bytes ducktape https://buildkite.com/redpanda/redpanda/builds/60259#01942b9f-0cf0-4bd8-80a0-3a21f42f9ed4 FAIL 0/1

@mmaslankaprv mmaslankaprv merged commit d2ed3ec into redpanda-data:v24.2.x Jan 3, 2025
14 of 18 checks passed
@mmaslankaprv mmaslankaprv deleted the manual-backport-24664-v24.2.x-960 branch January 3, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ztlpn ztlpn ztlpn approved these changes

@bharathv bharathv Awaiting requested review from bharathv

Assignees
No one assigned
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v24.2.15
Development

Successfully merging this pull request may close these issues.
4 participants
@mmaslankaprv @vbotbuildovich @ztlpn @piyushredpanda