Do not download the partition manifest when creating learner #24664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When learner replica is created its state should not be seeded by the recovery machinery but rather than that it must be recovered by Raft. Using remote recovery when creating the learner replicas may lead to archival_stm issues as some commands are applied more than once. Signed-off-by: Michał Maślanka <michal@redpanda.com>
Added tests triggering partition replica set reconfiguration with topics which are recovered. Signed-off-by: Michał Maślanka <michal@redpanda.com>
Lazin
approved these changes
Jan 2, 2025
Retry command for Build#60220please wait until all jobs are finished before running the slash command |
CI test resultstest results on build#60220
|
ztlpn
reviewed
Jan 2, 2025
| self.redpanda.start_node(self.redpanda.nodes[4]) | ||
| self.wait_for_partitions_rebalanced(total_replicas=total_replicas, | ||
| timeout_sec=self.rebalance_timeout) | ||
| self.redpanda.wait_for_manifest_uploads() |
There was a problem hiding this comment.
should we wait for this before adding nodes? (well, I guess both cases are interesting)
ztlpn
approved these changes
Jan 2, 2025
|
/backport v24.3.x |
|
/backport v24.2.x |
|
Failed to create a backport PR to v24.2.x branch. I tried: |
This was referenced Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When learner replica is created its state should not be seeded by the
recovery machinery but rather than that it must be recovered by Raft.
Using remote recovery when creating the learner replicas may lead to
archival_stmissues as some commands are applied more than once.Backports Required
Release Notes
Bug Fixes
archival_metadata_stminconsistencies when reconfiguring clusters with recovered compacted topics.