Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Php55][Renaming] Handle rename string on combination StringClassNameToClassConstantRector+RenameStringRector #4869

Merged
merged 5 commits into from
Aug 28, 2023

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Aug 28, 2023

Fixes rectorphp/rector#8160

StringClassNameToClassConstantRector directly use return NodeTraverser::DONT_TRAVERSE_CHILDREN on a refactor that cause other rule stopped:

if ($node instanceof FuncCall) {
if ($this->isName($node, 'is_a')) {
return NodeTraverser::DONT_TRAVERSE_CHILDREN;
}
return null;
}

this should only stop below on current rule only.

This PR also a rework of PR:

@samsonasik
Copy link
Member Author

@TomasVotruba it works 🎉

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RenameStringRector not run after StringClassNameToClassConstantRector
2 participants